GNOME Bugzilla – Bug 782601
batch-rename-dialog: untranslatable strings
Last modified: 2017-05-13 17:59:03 UTC
Three strings in src/nautilus-batch-rename-dialog.c are not marked for translation.
Created attachment 351787 [details] [review] batch-rename-dialog: mark strings as translatable
While we're here, I would suggest changing "an unallowed" to "a disallowed" first
(In reply to Daniel Boles from comment #2) > While we're here, I would suggest changing "an unallowed" to "a disallowed" > first Or maybe “is not a valid”?
Created attachment 351788 [details] [review] batch-rename-dialog: fix grammar in translatable strings “Unallowed” is not an English word. :)
I used strings that are already present in Nautilus, so the impact for translators is minimal.
Review of attachment 351787 [details] [review]: Yup!
Review of attachment 351788 [details] [review]: Beautiful, thanks!
Squash the patches if you’re going to push them, though.
I’m sorry, I pushed them before your last comment. Should I squash them when backporting to gnome-3-24?
Comment on attachment 351787 [details] [review] batch-rename-dialog: mark strings as translatable https://git.gnome.org/browse/nautilus/commit/?id=5713949603ca91d6f71beae0dc149bfd23bcde7c
Comment on attachment 351788 [details] [review] batch-rename-dialog: fix grammar in translatable strings https://git.gnome.org/browse/nautilus/commit/?id=8480203d1a9a58b48322f031ec9a0c7fab73454b
(In reply to Piotr Drąg from comment #9) > I’m sorry, I pushed them before your last comment. Should I squash them when > backporting to gnome-3-24? Nah, I think it’s fine to separate the changes.
Pushed to gnome-3-24: https://git.gnome.org/browse/nautilus/commit/?h=gnome-3-24&id=1d22e8e4f64cd9c43af2b33118a806786808ddc6 https://git.gnome.org/browse/nautilus/commit/?h=gnome-3-24&id=a502e23d92eb063841141a6df7ba92042dad8fa0 Thank you guys!