After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782600 - views: handle keyboard activation in files-view
views: handle keyboard activation in files-view
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-13 17:34 UTC by Ernestas Kulik
Modified: 2017-05-14 09:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
views: handle keyboard activation in files-view (5.13 KB, patch)
2017-05-13 17:34 UTC, Ernestas Kulik 		none Details | Review
views: handle keyboard activation in files-view (6.28 KB, patch)
2017-05-14 09:14 UTC, Ernestas Kulik 		committed Details | Review

Description Ernestas Kulik 2017-05-13 17:34:15 UTC 
Each view handles keyboard activation on its own by listening to
key-press-event, yet there are actions in files-view that could handle
it. This commit makes it so, additionally swapping the accelerators for
opening in new tab and window to make things more consistent throughout
the application (and others, too, e.g. Firefox).
Comment 1 Ernestas Kulik 2017-05-13 17:34:21 UTC 
Created attachment 351786 [details] [review]
views: handle keyboard activation in files-view
Comment 2 Carlos Soriano 2017-05-14 08:31:45 UTC 
Review of attachment 351786 [details] [review]:

You are missing the shortcuts window
Comment 3 Ernestas Kulik 2017-05-14 09:14:27 UTC 
Created attachment 351809 [details] [review]
views: handle keyboard activation in files-view

Each view handles keyboard activation on its own by listening to
key-press-event, yet there are actions in files-view that could handle
it. This commit makes it so, additionally swapping the accelerators for
opening in new tab and window to make things more consistent throughout
the application (and others, too, e.g. Firefox).
Comment 4 Carlos Soriano 2017-05-14 09:18:25 UTC 
Review of attachment 351809 [details] [review]:

+1!
Comment 5 Carlos Soriano 2017-05-14 09:18:27 UTC 
Review of attachment 351809 [details] [review]:

+1!
Comment 6 Ernestas Kulik 2017-05-14 09:21:38 UTC 
Attachment 351809 [details] pushed as fb8b8ca - views: handle keyboard activation in files-view