After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782572 - the signedness warnings may (and should) be fixed
the signedness warnings may (and should) be fixed
Status: RESOLVED OBSOLETE
Product: planner
Classification: Other
Component: Build
0.14.x
Other Linux
: Normal normal
: ---
Assigned To: planner-maint
planner-maint
Depends on:
Blocks:
 
 
Reported: 2017-05-12 19:28 UTC by Andrew Miloradovsky
Modified: 2021-06-09 20:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
signedness: prevent g(u)char and g(u)int conversion (2.49 KB, patch)
2017-05-12 19:30 UTC, Andrew Miloradovsky
none Details | Review
signedness: explicitly cast the xmlChar to/from gchar type (31.05 KB, patch)
2017-05-12 19:31 UTC, Andrew Miloradovsky
none Details | Review
signedness: explicitly cast the xmlChar to/from gchar type (31.87 KB, patch)
2017-05-12 19:52 UTC, Andrew Miloradovsky
none Details | Review
signedness: explicitly cast the xmlChar to/from gchar type (33.66 KB, patch)
2017-05-12 20:26 UTC, Andrew Miloradovsky
none Details | Review

Description Andrew Miloradovsky 2017-05-12 19:28:56 UTC
./autogen.sh --enable-compile-warnings=yes  # or =error

The xmlChar warnings are silly and worth ignoring, but because of them it's difficult to spot a more legitimate ones, like gchar/guchar and gint/guint.
So fixed all of them. The patches are in the way...
Comment 1 Andrew Miloradovsky 2017-05-12 19:30:54 UTC
Created attachment 351747 [details] [review]
signedness: prevent g(u)char and g(u)int conversion
Comment 2 Andrew Miloradovsky 2017-05-12 19:31:20 UTC
Created attachment 351748 [details] [review]
signedness: explicitly cast the xmlChar to/from gchar type
Comment 3 Andrew Miloradovsky 2017-05-12 19:52:36 UTC
Created attachment 351751 [details] [review]
signedness: explicitly cast the xmlChar to/from gchar type

forgot the planner-msp-plugin
Comment 4 Andrew Miloradovsky 2017-05-12 20:26:25 UTC
Created attachment 351759 [details] [review]
signedness: explicitly cast the xmlChar to/from gchar type

touch the scheduler-test too
Comment 5 Andrew Miloradovsky 2017-05-12 21:08:33 UTC
To recap. Now it's possible to

$ git reset --hard master  # 0f1ee22fe2e3a0646549ece1a5058ca348c54fb3

Then, in any order

$ git bz apply 782227  # Glib 2.36
$ git bz apply 782572  # signedness warnings
$ git bz apply 782346  # missing index.sgml
$ git bz apply 584556  # GDA 5

$ ./autogen.sh --enable-compile-warnings=yes --enable-gtk-doc --enable-simple-priority-scheduling --enable-python-plugin --with-database
$ make
$ make check

Succeed. And

$ make distcheck

provides the tarball (planner-0.14.6.tar.gz), with all the default options.

Everything without a single warning. Although liveness of all the features and whether it's possible/necessary to reanimate the Evolution plugin is still a question.
Comment 6 Ahmed Baïzid 2017-05-12 22:42:58 UTC
(In reply to Andrew Miloradovsky from comment #5)
> To recap. Now it's possible to (...)
> provides the tarball (planner-0.14.6.tar.gz), with all the default options.
> Everything without a single warning.

The C compiler might not warn anymore. The build system still does.

But, this is not the place to talk about that. 
This bug is about signed/unsigned char in C code.
Comment 7 Andrew Miloradovsky 2017-05-12 22:53:25 UTC
(In reply to Ahmed Baïzid from comment #6)
> (In reply to Andrew Miloradovsky from comment #5)
> > To recap. Now it's possible to (...)
> > provides the tarball (planner-0.14.6.tar.gz), with all the default options.
> > Everything without a single warning.
> 
> The C compiler might not warn anymore. The build system still does.
Those warnings aren't that explicit and clear, need more investigation.

> But, this is not the place to talk about that. 
> This bug is about signed/unsigned char in C code.
...and int, but mostly about xmlChar...

Anyway. Sure. I just wanted to put it in context. Scope etc.
Comment 8 Ahmed Baïzid 2017-06-06 16:27:17 UTC
This bug should not be in the "Build" component of the "Planner" product.
Comment 9 GNOME Infrastructure Team 2021-06-09 20:48:38 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/World/planner/-/issues/230.