GNOME Bugzilla – Bug 782572
the signedness warnings may (and should) be fixed
Last modified: 2021-06-09 20:48:38 UTC
./autogen.sh --enable-compile-warnings=yes # or =error The xmlChar warnings are silly and worth ignoring, but because of them it's difficult to spot a more legitimate ones, like gchar/guchar and gint/guint. So fixed all of them. The patches are in the way...
Created attachment 351747 [details] [review] signedness: prevent g(u)char and g(u)int conversion
Created attachment 351748 [details] [review] signedness: explicitly cast the xmlChar to/from gchar type
Created attachment 351751 [details] [review] signedness: explicitly cast the xmlChar to/from gchar type forgot the planner-msp-plugin
Created attachment 351759 [details] [review] signedness: explicitly cast the xmlChar to/from gchar type touch the scheduler-test too
To recap. Now it's possible to $ git reset --hard master # 0f1ee22fe2e3a0646549ece1a5058ca348c54fb3 Then, in any order $ git bz apply 782227 # Glib 2.36 $ git bz apply 782572 # signedness warnings $ git bz apply 782346 # missing index.sgml $ git bz apply 584556 # GDA 5 $ ./autogen.sh --enable-compile-warnings=yes --enable-gtk-doc --enable-simple-priority-scheduling --enable-python-plugin --with-database $ make $ make check Succeed. And $ make distcheck provides the tarball (planner-0.14.6.tar.gz), with all the default options. Everything without a single warning. Although liveness of all the features and whether it's possible/necessary to reanimate the Evolution plugin is still a question.
(In reply to Andrew Miloradovsky from comment #5) > To recap. Now it's possible to (...) > provides the tarball (planner-0.14.6.tar.gz), with all the default options. > Everything without a single warning. The C compiler might not warn anymore. The build system still does. But, this is not the place to talk about that. This bug is about signed/unsigned char in C code.
(In reply to Ahmed Baïzid from comment #6) > (In reply to Andrew Miloradovsky from comment #5) > > To recap. Now it's possible to (...) > > provides the tarball (planner-0.14.6.tar.gz), with all the default options. > > Everything without a single warning. > > The C compiler might not warn anymore. The build system still does. Those warnings aren't that explicit and clear, need more investigation. > But, this is not the place to talk about that. > This bug is about signed/unsigned char in C code. ...and int, but mostly about xmlChar... Anyway. Sure. I just wanted to put it in context. Scope etc.
This bug should not be in the "Build" component of the "Planner" product.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/World/planner/-/issues/230.