After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782563 - splitmuxsink: Add alignment-threshold argument
splitmuxsink: Add alignment-threshold argument
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-12 15:00 UTC by Vivia Nikolaidou
Modified: 2017-05-16 12:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
splitmuxsink: Add alignment-threshold argument (5.27 KB, patch)
2017-05-12 15:00 UTC, Vivia Nikolaidou
none Details | Review
splitmuxsink: Add alignment-threshold argument (5.27 KB, patch)
2017-05-16 12:21 UTC, Vivia Nikolaidou
committed Details | Review

Description Vivia Nikolaidou 2017-05-12 15:00:42 UTC
See commit message
Comment 1 Vivia Nikolaidou 2017-05-12 15:00:46 UTC
Created attachment 351731 [details] [review]
splitmuxsink: Add alignment-threshold argument

If a non-reference stream is behind the reference stream by an amount of
time smaller than the alignment threshold (in nsec), it counts as being
after it.
Comment 2 Sebastian Dröge (slomo) 2017-05-16 12:10:34 UTC
Review of attachment 351731 [details] [review]:

::: gst/multifile/gstsplitmuxsink.c
@@ +641,3 @@
+
+    if (!(splitmux->max_out_running_time == 0 ||
+            splitmux->max_out_running_time == GST_CLOCK_TIME_NONE ||

Needs to be STIME

@@ +644,3 @@
+            splitmux->alignment_threshold == 0 ||
+            splitmux->max_out_running_time < splitmux->alignment_threshold)) {
+      my_max_out_running_time -= splitmux->alignment_threshold;

If splitmux->max_out_running_time < splitmux->alignment_threshold, you probably want to set it to 0 here?
Comment 3 Vivia Nikolaidou 2017-05-16 12:18:08 UTC
(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 351731 [details] [review] [review]:
> 
> @@ +644,3 @@
> +            splitmux->alignment_threshold == 0 ||
> +            splitmux->max_out_running_time <
> splitmux->alignment_threshold)) {
> +      my_max_out_running_time -= splitmux->alignment_threshold;
> 
> If splitmux->max_out_running_time < splitmux->alignment_threshold, you
> probably want to set it to 0 here?

That's essentially what I do by skipping the if: my_max_out_running_time is the same as splitmux->max_out_running_time, therefore it's the same as the alignment_threshold being 0. Basically that probably means that either it's too early in the stream, or the user set the alignment_threshold to something too high, or maybe both.
Comment 4 Vivia Nikolaidou 2017-05-16 12:21:31 UTC
Created attachment 351969 [details] [review]
splitmuxsink: Add alignment-threshold argument

If a non-reference stream is behind the reference stream by an amount of
time smaller than the alignment threshold (in nsec), it counts as being
after it.
Comment 5 Sebastian Dröge (slomo) 2017-05-16 12:31:47 UTC
Attachment 351969 [details] pushed as a910329 - splitmuxsink: Add alignment-threshold argument