Created attachment 351731 [details] [review]
splitmuxsink: Add alignment-threshold argument

If a non-reference stream is behind the reference stream by an amount of
time smaller than the alignment threshold (in nsec), it counts as being
after it.

Review of attachment 351731 [details] [review]:

::: gst/multifile/gstsplitmuxsink.c
@@ +641,3 @@
+
+    if (!(splitmux->max_out_running_time == 0 ||
+            splitmux->max_out_running_time == GST_CLOCK_TIME_NONE ||

Needs to be STIME

@@ +644,3 @@
+            splitmux->alignment_threshold == 0 ||
+            splitmux->max_out_running_time < splitmux->alignment_threshold)) {
+      my_max_out_running_time -= splitmux->alignment_threshold;

If splitmux->max_out_running_time < splitmux->alignment_threshold, you probably want to set it to 0 here?

(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 351731 [details] [review] [review]:
> 
> @@ +644,3 @@
> +            splitmux->alignment_threshold == 0 ||
> +            splitmux->max_out_running_time <
> splitmux->alignment_threshold)) {
> +      my_max_out_running_time -= splitmux->alignment_threshold;
> 
> If splitmux->max_out_running_time < splitmux->alignment_threshold, you
> probably want to set it to 0 here?

That's essentially what I do by skipping the if: my_max_out_running_time is the same as splitmux->max_out_running_time, therefore it's the same as the alignment_threshold being 0. Basically that probably means that either it's too early in the stream, or the user set the alignment_threshold to something too high, or maybe both.

Created attachment 351969 [details] [review]
splitmuxsink: Add alignment-threshold argument

If a non-reference stream is behind the reference stream by an amount of
time smaller than the alignment threshold (in nsec), it counts as being
after it.

Attachment 351969 [details] pushed as a910329 - splitmuxsink: Add alignment-threshold argument