After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782528 - Child widgets shouldn't hold references to their parents
Child widgets shouldn't hold references to their parents
Status: RESOLVED OBSOLETE
Product: gnome-documents
Classification: Core
Component: general
3.24.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-05-11 18:26 UTC by Debarshi Ray
Modified: 2021-07-05 11:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
overview, selections: A child shouldn't hold a reference to its parent (5.09 KB, patch)
2017-05-11 18:27 UTC, Debarshi Ray 		committed Details | Review
overview: ViewContainer shouldn't hold a reference to OverviewStack (2.61 KB, patch)
2017-05-11 18:27 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2017-05-11 18:26:32 UTC 
We have a few cases where child widgets are holding references to their parent containers via instance member variables. Unless really necessary, I think we should avoid doing this to stay clear of reference cycles.
Comment 1 Debarshi Ray 2017-05-11 18:27:32 UTC 
Created attachment 351660 [details] [review]
overview, selections: A child shouldn't hold a reference to its parent
Comment 2 Debarshi Ray 2017-05-11 18:27:44 UTC 
Created attachment 351661 [details] [review]
overview: ViewContainer shouldn't hold a reference to OverviewStack
Comment 3 Cosimo Cecchi 2017-05-11 19:19:32 UTC 
Review of attachment 351660 [details] [review]:

OK
Comment 4 Cosimo Cecchi 2017-05-11 19:20:05 UTC 
Review of attachment 351661 [details] [review]:

OK
Comment 5 GNOME Infrastructure Team 2021-07-05 11:30:49 UTC 
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/gnome-documents/-/issues/

Thank you for your understanding and your help.