After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782519 - qtdemux: Fix caps leak in _parse_trak()
qtdemux: Fix caps leak in _parse_trak()
Status: RESOLVED DUPLICATE of bug 684790
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-11 13:36 UTC by Seungha Yang
Modified: 2017-05-11 15:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtdemux: Fix caps leak in _parse_trak() (1.21 KB, patch)
2017-05-11 13:38 UTC, Seungha Yang 		reviewed Details | Review

Description Seungha Yang 2017-05-11 13:36:20 UTC 
If upstream pushed moov multiple times during playback
such as DASH case, it causes memory leak.
Comment 1 Seungha Yang 2017-05-11 13:38:37 UTC 
Created attachment 351638 [details] [review]
qtdemux: Fix caps leak in _parse_trak()
Comment 2 Sebastian Dröge (slomo) 2017-05-11 14:52:35 UTC 
Review of attachment 351638 [details] [review]:

::: gst/isomp4/qtdemux.c
@@ +11573,3 @@
 
+      if (entry->caps)
+        gst_caps_unref (entry->caps);

Shouldn't this have been cleared somewhere when getting the new moov before parsing it? All of the entries and other information from the previous moov.
Comment 3 Seungha Yang 2017-05-11 15:09:43 UTC 
(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 351638 [details] [review] [review]:

> Shouldn't this have been cleared somewhere when getting the new moov before
> parsing it? All of the entries and other information from the previous moov.

Actually, all the stream specific information can be cleared if we generate stream/entries per moov like bug #684790 :)
Comment 4 Sebastian Dröge (slomo) 2017-05-11 15:29:21 UTC 
Then let's solve it once and for all there :)

*** This bug has been marked as a duplicate of bug 684790 ***