After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782501 - retro-gtk: Port to C
retro-gtk: Port to C
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: retro-gtk
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-11 08:20 UTC by Adrien Plazas
Modified: 2017-10-10 17:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix C code indentation and style (40.42 KB, patch)
2017-05-11 08:36 UTC, Adrien Plazas
committed Details | Review
Port the variable interface to C (23.23 KB, patch)
2017-09-12 09:56 UTC, Adrien Plazas
committed Details | Review
build: Drop Vala (6.34 KB, patch)
2017-10-10 17:30 UTC, Adrien Plazas
committed Details | Review

Description Adrien Plazas 2017-05-11 08:20:43 UTC
C makes more sens for retro-gtk as it is a somewhat low level library dealing with many C symbols, hence we should port retro-gtk to C.

We should ensure to keep producing a valid VAPI and to keep the library introspectable.
Comment 1 Adrien Plazas 2017-05-11 08:36:37 UTC
Created attachment 351605 [details] [review]
Fix C code indentation and style

This will help to make the style consistent as more C code will be
added.
Comment 2 Adrien Plazas 2017-05-11 08:38:38 UTC
Comment on attachment 351605 [details] [review]
Fix C code indentation and style

Attachment 351605 [details] pushed as e3adfa4 - Fix C code indentation and style
Comment 3 Adrien Plazas 2017-09-12 09:56:01 UTC
Created attachment 359594 [details] [review]
Port the variable interface to C

Also tweak the API to make it simpler and drop the useless Variables
interface.
Comment 4 Adrien Plazas 2017-09-12 09:57:36 UTC
Comment on attachment 359594 [details] [review]
Port the variable interface to C

Attachment 359594 [details] pushed as f9f7801 - Port the variable interface to C
Comment 5 Adrien Plazas 2017-10-10 17:30:55 UTC
Created attachment 361257 [details] [review]
build: Drop Vala

This completes the port of retro-gtk fromo Vala to C.
Comment 6 Adrien Plazas 2017-10-10 17:33:38 UTC
Attachment 361257 [details] pushed as c578c10 - build: Drop Vala