After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782479 - Merge PhotosMainToolbar and PhotosHeaderbar
Merge PhotosMainToolbar and PhotosHeaderbar
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.23.x
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-05-10 19:52 UTC by Alessandro Bono
Modified: 2018-01-17 17:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main-toolbar: Merge PhotosHeaderBar (18.54 KB, patch)
2017-05-10 19:53 UTC, Alessandro Bono 		none Details | Review
Merge PhotosHeaderBar into PhotosMainToolbar (16.03 KB, patch)
2018-01-17 17:04 UTC, Debarshi Ray 		committed Details | Review

Description Alessandro Bono 2017-05-10 19:52:08 UTC 
PhotosHeaderbar is mainly used to set the style and the GtkStackSwitcher, merge them since PhotosMainToolbar already have the code for mode switching. Also, in Documents such differentiation doesn't exist.
Comment 1 Alessandro Bono 2017-05-10 19:53:31 UTC 
Created attachment 351577 [details] [review]
main-toolbar: Merge PhotosHeaderBar
Comment 2 Debarshi Ray 2018-01-17 17:04:31 UTC 
Created attachment 366956 [details] [review]
Merge PhotosHeaderBar into PhotosMainToolbar

Rebased against current master.
Comment 3 Debarshi Ray 2018-01-17 17:30:04 UTC 
From #photos on GIMPNet:

17:05 <~rishi> uajain: Want to quickly test this patch from abono:              
      https://bugzilla.gnome.org/show_bug.cgi?id=782479 ?
17:05 <bugbot> Bug 782479: general, normal, gnome-photos-maint, NEW , Merge     
      PhotosMainToolbar and PhotosHeaderbar
17:23 <uajain> rishi: Looks good!