After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782468 - Add GdTaggedEntry test case to mimic gnome-documents' widget hierarchy
Add GdTaggedEntry test case to mimic gnome-documents' widget hierarchy
Status: RESOLVED FIXED
Product: libgd
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libgd maintainer(s)
libgd maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-05-10 17:38 UTC by Debarshi Ray
Modified: 2017-05-12 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add GdTaggedEntry test case to mimic gnome-documents' widget hierarchy (5.76 KB, patch)
2017-05-10 17:39 UTC, Debarshi Ray 		none Details | Review
Add GdTaggedEntry test case to mimic gnome-documents' widget hierarchy (5.67 KB, patch)
2017-05-11 13:18 UTC, Debarshi Ray 		committed Details | Review
Add GdTaggedEntry test case to mimic gnome-documents' widget hierarchy (5.67 KB, patch)
2017-05-12 16:16 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2017-05-10 17:38:26 UTC 
Lapo noticed that his entry-tag CSS to style GdTaggedEntry was not having the same effect in gnome-documents as it was test-tagged-entry.c. I haven't found the root cause but it would be good to have another test case that mimics the widget hierarchy of gnome-documents. Working with git submodules is painful. Having more test cases can assuage the situation.
Comment 1 Debarshi Ray 2017-05-10 17:39:30 UTC 
Created attachment 351572 [details] [review]
Add GdTaggedEntry test case to mimic gnome-documents' widget hierarchy
Comment 2 Debarshi Ray 2017-05-11 13:18:34 UTC 
Created attachment 351627 [details] [review]
Add GdTaggedEntry test case to mimic gnome-documents' widget hierarchy

This is better because it uses a GtkSearchBar instead of GtkToolbar/GtkToolItem.
Comment 3 Cosimo Cecchi 2017-05-11 19:22:07 UTC 
Review of attachment 351627 [details] [review]:

Feel free to push with this fixed

::: test-tagged-entry-2.c
@@ +88,3 @@
+  entry = GTK_WIDGET (gd_tagged_entry_new ());
+  gtk_widget_set_size_request (entry, 500, -1);
+  g_signal_connect(entry, "tag-clicked",

Add space before parent (also below)
Comment 4 Debarshi Ray 2017-05-12 16:16:27 UTC 
Created attachment 351738 [details] [review]
Add GdTaggedEntry test case to mimic gnome-documents' widget hierarchy

Pushed after adding the missing whitespace. Thanks for the review, Cosimo!