After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782449 - Fails to build with exiv2-0.26
Fails to build with exiv2-0.26
Status: RESOLVED FIXED
Product: gexiv2
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Gexiv2 Maintainers
Gexiv2 Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-10 15:19 UTC by Debarshi Ray
Modified: 2017-06-30 13:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Adapt to Exiv2::BasicIo API change (1.33 KB, patch)
2017-05-10 15:26 UTC, Debarshi Ray
none Details | Review
iostream: Adapt to new Exiv2 API in 0.26 (1.77 KB, patch)
2017-05-12 17:54 UTC, Jens Georg
none Details | Review
iostream: Adapt to new Exiv2 API in 0.26 (1.80 KB, patch)
2017-05-12 18:11 UTC, Jens Georg
committed Details | Review
Adapt to Exiv2::BasicIo API change (1.87 KB, patch)
2017-06-30 13:38 UTC, Debarshi Ray
none Details | Review

Description Debarshi Ray 2017-05-10 15:19:17 UTC
Exiv2::BasicIo::size() changed its return type to size_t from long:
http://dev.exiv2.org/issues/1175

That leads to:
  CXX      gexiv2/libgexiv2_la-gexiv2-stream-io.lo
In file included from gexiv2/gexiv2-stream-io.cpp:13:0:
gexiv2/gexiv2-stream-io.h:42:15: error: conflicting return type specified for 'virtual long int StreamIo::size() const'
  virtual long size () const;
               ^~~~
In file included from gexiv2/gexiv2-stream-io.h:19:0,
                 from gexiv2/gexiv2-stream-io.cpp:13:
/usr/include/exiv2/basicio.hpp:225:24: error:   overriding 'virtual size_t Exiv2::BasicIo::size() const'
         virtual size_t size() const = 0;
                        ^~~~
Here is a build log:
https://kojipkgs.fedoraproject.org//work/tasks/6096/19376096/build.log
Comment 1 Debarshi Ray 2017-05-10 15:26:08 UTC
Created attachment 351561 [details] [review]
Adapt to Exiv2::BasicIo API change
Comment 2 Jens Georg 2017-05-12 17:54:20 UTC
Created attachment 351743 [details] [review]
iostream: Adapt to new Exiv2 API in 0.26

Signed-off-by: Jens Georg <mail@jensge.org>


I would go with this approach for the 0.10 stable version and use your patch
for the unstable branch.
Comment 3 Jens Georg 2017-05-12 18:11:37 UTC
Created attachment 351745 [details] [review]
iostream: Adapt to new Exiv2 API in 0.26

Whoops. Wrong version
Comment 4 Jens Georg 2017-05-12 18:21:10 UTC
Attachment 351745 [details] pushed as f295c5c - iostream: Adapt to new Exiv2 API in 0.26
Comment 5 Debarshi Ray 2017-06-30 13:38:31 UTC
Created attachment 354732 [details] [review]
Adapt to Exiv2::BasicIo API change

For the sake of completeness, I realized that I forgot to 'git add configure.ac'.