After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782345 - decklink build fails on windows
decklink build fails on windows
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other Windows
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-08 18:11 UTC by Scott D Phillips
Modified: 2017-05-08 18:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] meson: Ignore msvc warnings in C++ as well (1.54 KB, patch)
2017-05-08 18:11 UTC, Scott D Phillips
committed Details | Review

Description Scott D Phillips 2017-05-08 18:11:14 UTC
Created attachment 351382 [details] [review]
[PATCH] meson: Ignore msvc warnings in C++ as well

I get this build failure:

> [2/80] Compiling cpp object subprojects/gst-plugins-bad/sys/decklink/gstdecklink@sha/gstdecklinkvideosrc.cpp.obj
> FAILED: subprojects/gst-plugins-bad/sys/decklink/gstdecklink@sha/gstdecklinkvideosrc.cpp.obj
> cl @subprojects/gst-plugins-bad/sys/decklink/gstdecklink@sha/gstdecklinkvideosrc.cpp.obj.rsp
> c:\users\scott-ph\downloads\gst-build\subprojects\gst-plugins-bad\sys\decklink\gstdecklinkvideosrc.cpp(527): error C2220: warning treated as error - no 'object' file generated
> c:\users\scott-ph\downloads\gst-build\subprojects\gst-plugins-bad\sys\decklink\gstdecklinkvideosrc.cpp(527): warning C4244: 'initializing': conversion from 'gdouble' to 'guint', possible loss of data

4244 is one of the msvc warnings we ignore, but it is not being ignored for C++.
Comment 1 Tim-Philipp Müller 2017-05-08 18:18:47 UTC
Thanks!

commit 0309b20098fff102b73f6ac0a5d2ff1b220d090a
Author: Scott D Phillips <scott.d.phillips@intel.com>
Date:   Mon May 8 11:01:39 2017 -0700

    meson: Ignore msvc warnings in C++ as well
    
    We were only ignoring the listed msvc warnings for C language
    files and not C++. This was working by the coincidence that we did
    not have any instances of these warnings in C++ files. Lately the
    build of decklink has been fixed on windows, and it has an
    instance of one of these warnings in a C++ file.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=782345