After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782330 - adaptivedemux: Handle more live seeking use-cases
adaptivedemux: Handle more live seeking use-cases
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-08 13:41 UTC by Edward Hervey
Modified: 2017-05-09 07:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
adaptivedemux: Handle more live seeking use-cases (4.35 KB, patch)
2017-05-08 13:41 UTC, Edward Hervey
committed Details | Review

Description Edward Hervey 2017-05-08 13:41:11 UTC
See commit message
Comment 1 Edward Hervey 2017-05-08 13:41:15 UTC
Created attachment 351353 [details] [review]
adaptivedemux: Handle more live seeking use-cases

This commit fixes the following assumptions with live seeking:
1) start was always valid and of type GST_SEEK_TYPE_SET
2) direction was always forward
3) stop should be offsetted when handling non-accurate seeks before
   the range start position.

In order to handle more live seeking use-cases (including reverse playback),
only do non-accurate start/stop value clamping for GST_SEEK_TYPE_SET values.

Also add a bit more debugging lines for issues
Comment 2 Edward Hervey 2017-05-09 07:05:00 UTC
commit ea6e58d27fabc6a5f671bae3e885896c4a3b8b50
Author: Edward Hervey <edward@centricular.com>
Date:   Mon May 8 15:34:50 2017 +0200

    adaptivedemux: Handle more live seeking use-cases
    
    This commit fixes the following assumptions with live seeking:
    1) start was always valid and of type GST_SEEK_TYPE_SET
    2) direction was always forward
    3) stop should be offsetted when handling non-accurate seeks before
       the range start position.
    
    In order to handle more live seeking use-cases (including reverse playback),
    only do non-accurate start/stop value clamping for GST_SEEK_TYPE_SET values.
    
    Also add a bit more debugging lines for issues
    
    https://bugzilla.gnome.org/show_bug.cgi?id=782330