After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782324 - Mahjongg doens't use properly primary-toolbar styled headerbar in Unity
Mahjongg doens't use properly primary-toolbar styled headerbar in Unity
Status: RESOLVED OBSOLETE
Product: gnome-mahjongg
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-mahjongg-maint
gnome-mahjongg-maint
Depends on:
Blocks:
 
 
Reported: 2017-05-08 11:42 UTC by Marco Trevisan (Treviño)
Modified: 2018-04-01 02:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use headerbar in toolbar-mode in Unity (848 bytes, patch)
2017-05-08 11:42 UTC, Marco Trevisan (Treviño)
none Details | Review

Description Marco Trevisan (Treviño) 2017-05-08 11:42:18 UTC
Created attachment 351344 [details] [review]
Use headerbar in toolbar-mode in Unity

In Mahjongg the headerbar in unity is used as a toolbar, but without applying the proper .primary-toolbar class, which leads to make impossible to use Unity themes properly in other environments (as GS) as they try to apply a toolbar-like theme to any headerbar that is not a titlebar (which might be in cases in other apps, where custom headerbar widgets are heavily used).
Comment 1 Michael Catanzaro 2017-05-08 15:28:59 UTC
We should just remove the separate unity codepath and set the header bar as the title bar always. It looks fine in Unity nowadays, since Ubuntu updated its GTK+ theme to support this long ago.
Comment 2 Marco Trevisan (Treviño) 2017-05-08 16:24:59 UTC
I'm the one who did the work in unity to support this (not really a theme thing, though, as we still have server-side shadows for CSD windows), but I'll be ok if upstream prefers that.

But the current state will be broken for Unity users by changes I'm doing to make the Ubuntu themes to work properly in gnome-shell.

So either way works for me.
Comment 3 slackaddict 2017-11-05 11:01:57 UTC
hi

dunno if this is the right thread/place to report (or the right way), in case please advise

according to this thread

https://ubuntu-mate.community/t/missing-mahjongg-layouts/15227/8

switching the window controls to the left overlaps the menu icon of gm

best regards
Comment 4 Jeremy Bicha 2018-04-01 02:39:30 UTC
The theme patch proposed here is obsolete so I'm closing this bug.