After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782317 - Gnome Software doens't use properly primary-toolbar styled headerbar in Unity
Gnome Software doens't use properly primary-toolbar styled headerbar in Unity
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Marco Trevisan (Treviño)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-05-08 08:57 UTC by Marco Trevisan (Treviño)
Modified: 2017-05-08 11:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gs-shell: use headerbar in toolbar-mode in Unity (1.37 KB, patch)
2017-05-08 08:57 UTC, Marco Trevisan (Treviño)
none Details | Review
gs-shell: use headerbar in toolbar-mode in Unity (1.37 KB, patch)
2017-05-08 08:59 UTC, Marco Trevisan (Treviño)
none Details | Review
gs-shell: use headerbar in toolbar-mode in Unity (1.27 KB, patch)
2017-05-08 09:09 UTC, Marco Trevisan (Treviño)
accepted-commit_now Details | Review

Description Marco Trevisan (Treviño) 2017-05-08 08:57:46 UTC
Created attachment 351328 [details] [review]
gs-shell: use headerbar in toolbar-mode in Unity

In Gnome-Software the headerbar in unity is used as a toolbar, but without applying the proper .primary-toolbar class, which leads to make impossible to use Unity themes properly in other environments (as GS) as they try to apply a toolbar-like theme to any headerbar that is not a titlebar (which might be in cases in other apps, where custom headerbar widgets are heavily used).
Comment 1 Marco Trevisan (Treviño) 2017-05-08 08:59:34 UTC
Created attachment 351329 [details] [review]
gs-shell: use headerbar in toolbar-mode in Unity
Comment 2 Marco Trevisan (Treviño) 2017-05-08 09:09:44 UTC
Created attachment 351330 [details] [review]
gs-shell: use headerbar in toolbar-mode in Unity
Comment 3 Richard Hughes 2017-05-08 09:16:39 UTC
Review of attachment 351330 [details] [review]:

LGTM.