After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782299 - Fix build error when systemd is disabled
Fix build error when systemd is disabled
Status: RESOLVED FIXED
Product: gnome-packagekit
Classification: Core
Component: general
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: gnome-packagekit-maint
gnome-packagekit-maint
Depends on:
Blocks:
 
 
Reported: 2017-05-07 14:13 UTC by Ting-Wei Lan
Modified: 2017-05-08 14:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Fix configure failure when systemd is disabled (1.05 KB, patch)
2017-05-07 14:16 UTC, Ting-Wei Lan 		committed Details | Review
build: move llvm-config to the top (1.29 KB, patch)
2017-05-07 15:30 UTC, Ting-Wei Lan 		none Details | Review

Description Ting-Wei Lan 2017-05-07 14:13:27 UTC 
In meson.build, systemd and polkit are only defined when systemd is enabled, but the rule for gpk-update-viewer in src/meson.build uses them unconditionally, causing error when running meson:

Meson encountered an error in file src/meson.build, line 112, column 0:
Unknown variable "polkit".
Comment 1 Ting-Wei Lan 2017-05-07 14:16:04 UTC 
Created attachment 351301 [details] [review]
build: Fix configure failure when systemd is disabled
Comment 2 Ting-Wei Lan 2017-05-07 15:30:53 UTC 
Created attachment 351307 [details] [review]
build: move llvm-config to the top

If llvm-config exists, it should be the default LLVM version on the
system and we should use it by default. This change also syncs the
list with meson.

https://bugzilla.gnome.org/show_bug.cgi?id=782296
Comment 3 Ting-Wei Lan 2017-05-07 15:32:59 UTC 
Comment on attachment 351307 [details] [review]
build: move llvm-config to the top

Sorry, I attached this patch to a wrong bug report. Please ignore this attachment.
Comment 4 Richard Hughes 2017-05-08 09:13:59 UTC 
Review of attachment 351301 [details] [review]:

LGTM.
Comment 5 Ting-Wei Lan 2017-05-08 14:30:00 UTC 
Attachment 351301 [details] pushed as f42e29d - build: Fix configure failure when systemd is disabled