GNOME Bugzilla – Bug 782297
Add possibility to set User-Agent for requests
Last modified: 2017-05-20 21:34:41 UTC
Make it possible to override the default user-agent.
Created attachment 351298 [details] [review] Add possibility to set User-Agent for requests
Thanks, makes sense. Two comments: You apparently copy/pasted the code from ChamplainNetworkBboxTileSource to ChamplainNetworkTileSource and forgot to remove the "bbox" from CHAMPLAIN_IS_NETWORK_BBOX_TILE_SOURCE inside the champlain_network_tile_source_set_user_agent() implementation. Next, for consistency I'd prefer replacing ChamplainNetworkTileSource *self in function declarations to ChamplainNetworkTileSource *tile_source which is used everywhere else. Otherwise LGTM
Created attachment 351750 [details] [review] Add possibility to set User-Agent for requests
Sorry for the delay - looks good, committed. Thanks!