After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782295 - GameCollection should completely take care off the collection
GameCollection should completely take care off the collection
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-07 13:34 UTC by Adrien Plazas
Modified: 2017-05-07 14:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
core: Add GameCollection.get_list_store() (2.01 KB, patch)
2017-05-07 14:39 UTC, Adrien Plazas 		committed Details | Review
core: Add GameCollection.search_games() (982 bytes, patch)
2017-05-07 14:39 UTC, Adrien Plazas 		committed Details | Review
ui: Make Application use GameCollection to handle games (2.14 KB, patch)
2017-05-07 14:39 UTC, Adrien Plazas 		committed Details | Review
core: Remove unused GameCollection.game_added() (1.04 KB, patch)
2017-05-07 14:39 UTC, Adrien Plazas 		committed Details | Review

Description Adrien Plazas 2017-05-07 13:34:38 UTC 
The GameCollection class should take care off the ListStore, adding games to it, etc… so that the Application class doesn't take care of the collection.
Comment 1 Adrien Plazas 2017-05-07 14:39:17 UTC 
Created attachment 351302 [details] [review]
core: Add GameCollection.get_list_store()

Also make GameCollection store games in the list store.

This will be used in the next commits to move game collection handling
out of the Application class.
Comment 2 Adrien Plazas 2017-05-07 14:39:23 UTC 
Created attachment 351303 [details] [review]
core: Add GameCollection.search_games()

This will be used in the next commits to move game collection handling
out of the Application class.
Comment 3 Adrien Plazas 2017-05-07 14:39:35 UTC 
Created attachment 351304 [details] [review]
ui: Make Application use GameCollection to handle games

This helps splitting the concerns of each class better.
Comment 4 Adrien Plazas 2017-05-07 14:39:41 UTC 
Created attachment 351305 [details] [review]
core: Remove unused GameCollection.game_added()

We stopped using it in the previous commit.
Comment 5 Adrien Plazas 2017-05-07 14:47:59 UTC 
Attachment 351302 [details] pushed as 0dd4470 - core: Add GameCollection.get_list_store()
Attachment 351303 [details] pushed as e6396a0 - core: Add GameCollection.search_games()
Attachment 351304 [details] pushed as 6234464 - ui: Make Application use GameCollection to handle games
Attachment 351305 [details] pushed as 1474bba - core: Remove unused GameCollection.game_added()