After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782286 - [review] add CList and use it for ifcfg-rh's shvar.c and libnm object code
[review] add CList and use it for ifcfg-rh's shvar.c and libnm object code
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-05-07 10:48 UTC by Thomas Haller
Modified: 2017-05-11 16:55 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Thomas Haller 2017-05-07 10:48:35 UTC
In NMPlatform, the route cache will have to be extended to preserve the order or routes. A circular, doubly-linked list like kernel's "struct list_head" or CList will be used for that. This data structure is nice for certain use-cases, because the linking infrastructure can be embedded in the linked objects, which is more efficient -- but only works if the linked object is only part of one list at a time, and if the linked object is aware of the linking altogether.


Import CList [1], and use it at a few places as show-case.

Please review th/c-list




[1] https://github.com/c-util/c-list
Comment 1 Beniamino Galvani 2017-05-10 07:33:59 UTC
LGTM
Comment 2 Thomas Haller 2017-05-11 16:55:03 UTC
lrintel ACKed on IRC too.

merged to master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=3063a5eda3cadf33ec7d302a24ea27f23a4d560b