After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782275 - Allow popping menu up with keyboard
Allow popping menu up with keyboard
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gui
git master
Other Linux
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2017-05-06 19:32 UTC by Ernestas Kulik
Modified: 2017-05-07 06:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Allow popping menu up with keyboard (6.19 KB, patch)
2017-05-06 19:33 UTC, Ernestas Kulik
committed Details | Review

Description Ernestas Kulik 2017-05-06 19:32:47 UTC
Crasher + enhancement. See patch.
Comment 1 Ernestas Kulik 2017-05-06 19:33:08 UTC
Created attachment 351267 [details] [review]
Allow popping menu up with keyboard

Currently, the code assumes that any attempt to pop up the menu will
come from a button press event, which is not true when using the
keyboard, in which case the assumption causes a crash.

This commit adds the ability to pop up the menu using the keyboard as
well.
Comment 2 Ignacio Casal Quinteiro (nacho) 2017-05-06 19:51:40 UTC
Review of attachment 351267 [details] [review]:

Looks pretty good
Comment 3 Ernestas Kulik 2017-05-07 06:16:42 UTC
Attachment 351267 [details] pushed as 6a9d3d7 - Allow popping menu up with keyboard