GNOME Bugzilla – Bug 782231
Remove all xrandr related functionality
Last modified: 2017-07-19 09:58:57 UTC
This is all being moved to mutter since it depends on the old org.gnome.Mutter.DisplayConfig which doesn't support scaling and thus is going to be deprecated.
Created attachment 351220 [details] [review] orientation: Remove plugin This functionality is moving to mutter.
Created attachment 351221 [details] [review] media-keys: Remove video-out and rotate-video handling These are the sole remaining users of the xrandr plugin DBus API which we want to remove in order to move the functionality to mutter. The key binding handling will be moved to mutter as well.
Created attachment 351222 [details] [review] power: Stop using an xrandr plugin setting to suspend on lid close In practice this shouldn't change behavior since it's unlikely people would have changed the setting from its default of GSD_XRANDR_BOOT_BEHAVIOUR_FOLLOW_LID. The setting hasn't really made sense since mutter took over all display configuration and we'll remove it soon.
Created attachment 351223 [details] [review] xrandr: Remove plugin This functionality is moving to mutter and the DBus API is no longer used.
Review of attachment 351220 [details] [review]: You'll also need to file a bug against gnome-session to update the session file. Otherwise the session will fail to start. > This functionality is moving to mutter. A bit short on details. Please use: See https://bugzilla... to reference the mutter bug in question. acn pending the mutter changes, obviously.
Review of attachment 351221 [details] [review]: I couldn't find anything in the mutter patches that implemented the equivalent of "VIDEO_OUT_KEY".
Review of attachment 351222 [details] [review]: Please check with the original author of this code. I didn't care for this code either fwiw.
Review of attachment 351223 [details] [review]: Again, needs a reference to gnome-session for it to start successfully.
(In reply to Bastien Nocera from comment #5) > You'll also need to file a bug against gnome-session to update the session > file. Otherwise the session will fail to start. Please update gnome-initial-setup and gnome-shell-extensions too. I think gnome-initial-setup does not need to start every gnome-settings-daemon plugin but we just copied gnome-shell's list since it was easiest.
Comment on attachment 351220 [details] [review] orientation: Remove plugin Attachment 351220 [details] pushed as 3d527b4 - orientation: Remove plugin
(In reply to Bastien Nocera from comment #6) > I couldn't find anything in the mutter patches that implemented the > equivalent of "VIDEO_OUT_KEY". This has meanwhile been implemented and pushed now. (In reply to Bastien Nocera from comment #7) > Please check with the original author of this code. I didn't care for this > code either fwiw. Ok, sent an email to Paolo Bonzini. His intent isn't completely clear to me from just reading https://git.gnome.org/browse/gnome-settings-daemon/commit/?id=a95d9cdf0d1e69c171a17af7fbb8f75869cd54b9 (In reply to Bastien Nocera from comment #8) > Again, needs a reference to gnome-session for it to start successfully. I'll push gnome-session, gnome-initial-setup and gnome-shell-extensions patches to trim the session components list. Attachment 351221 [details] pushed as e4ad610 - media-keys: Remove video-out and rotate-video handling Attachment 351222 [details] pushed as 5db4d74 - power: Stop using an xrandr plugin setting to suspend on lid close Attachment 351223 [details] pushed as cbf313e - xrandr: Remove plugin