GNOME Bugzilla – Bug 782198
Missing keyboard-key-*.svg icons
Last modified: 2017-05-08 13:00:35 UTC
This page: https://help.gnome.org/users/gnome-help/stable/keyboard-shortcuts-set.html links to a bunch of keyboard-key-*.svg icons which don't exist. The problem seems to be that the icon files are missing in gnome-help/Makefile.am.
Gunnar, I think this is a good opportunity for you to learn how to submit a git patch for gnome-user-docs. Does that sound like a good idea to you too?
Created attachment 351226 [details] [review] Install missing icons Sure, why not? I know how to make a diff (attached), but I'm not sure about the proper format for submitting a patch. Please advise.
Could you.. 1, Commit your changes to your local git tree. In your commit message, mention https://bugzilla.gnome.org/show_bug.cgi?id=782198 2. Run git-format-patch HEAD~ to make a patch that includes your commit message and authorship information
Created attachment 351227 [details] [review] Install missing icons Ok, done. The exact command I run was: git format-patch HEAD~
That patch is still missing authorship information. Please see https://wiki.gnome.org/Git/Developers#Contributing_patches - thanks a lot!
@André: I don't follow you. The top of the patch now looks like this: From 2aa06bd74e27bf7811c4f6ce87e4cf044ac5a269 Mon Sep 17 00:00:00 2001 From: Gunnar Hjalmarsson <gunnarhj@ubuntu.com> Date: Fri, 5 May 2017 20:01:38 +0200 Subject: [PATCH] Install missing icons - https://bugzilla.gnome.org/show_bug.cgi?id=782198 --- gnome-help/Makefile.am | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) And I'm there. :) You aren't suggesting that I add myself to the AUTHORS file, are you?
Great job so far! Yes, I think André was mistaken. Please add an empty line after "missing icons" before the GNOME bug in your commit message. Next, could you ask on the gnome-doc-list for review of this patch? Introduce yourself if you haven't already.
> Yes, I think André was mistaken. Uhm, indeed. I am sorry! Yes https://bugzilla.gnome.org/attachment.cgi?id=351227&action=edit does display author info. I was looking at https://bug782198.bugzilla-attachments.gnome.org/attachment.cgi?id=351227&action=diff&collapsed=&context=patch&format=raw&headers=1 instead, which does not. Sigh... Bugzilla. :(
Created attachment 351229 [details] [review] Install missing icons Ok, thanks for confirming, André. Anyway, I succeeded in tweaking the commit message as Jeremy suggested, and submitted a third patch. Thanks for the lesson!
Looks good, Gunnar. Thanks!
Review of attachment 351229 [details] [review]: Looks good.
Attachment 351229 [details] pushed as 3198702 - Install missing icons https://bugzilla.gnome.org/show_bug.cgi?id=782198