After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782170 - color: build test requires compiled schemas
color: build test requires compiled schemas
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: color
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2017-05-04 17:58 UTC by Jeremy Bicha
Modified: 2017-05-19 16:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
color: Make the testcase able to run uninstalled (2.38 KB, patch)
2017-05-19 16:28 UTC, Iain Lane
committed Details | Review
color: Make the testcase able to run uninstalled (2.43 KB, patch)
2017-05-19 16:59 UTC, Iain Lane
committed Details | Review

Description Jeremy Bicha 2017-05-04 17:58:37 UTC
Running 'make check' from gnome-settings-daemon 3.24.1 fails in a clean build environment because the color test can't find the compiled color schemas.

To be used in the test, the schemas must be compiled and GSETTINGS_SCHEMA_DIR set to their location.

This regression was introduced with this commit:
https://git.gnome.org/browse/gnome-settings-daemon/commit?id=749c9cf675
Comment 1 Iain Lane 2017-05-19 16:28:23 UTC
Created attachment 352166 [details] [review]
color: Make the testcase able to run uninstalled

Distributions might want to be able to run their tests during package
builds, for example.

Compile the schema and set GSETTINGS_SCHEMA_DIR to the build dir.

---

I don't know about the SUBDIRS change in Makefile.am. I wasn't getting the .xml file generated by make dependencies, so I reordered them to get it built first.
Comment 2 Jeremy Bicha 2017-05-19 16:48:17 UTC
Iain, thanks for getting this test working! :)
Comment 3 Richard Hughes 2017-05-19 16:53:50 UTC
Review of attachment 352166 [details] [review]:

LGTM.
Comment 4 Iain Lane 2017-05-19 16:59:46 UTC
The following fix has been pushed:
3923d60 color: Make the testcase able to run uninstalled
Comment 5 Iain Lane 2017-05-19 16:59:54 UTC
Created attachment 352172 [details] [review]
color: Make the testcase able to run uninstalled

Distributions might want to be able to run their tests during package
builds, for example.

Compile the schema and set GSETTINGS_SCHEMA_DIR to the build dir.