Created attachment 351025 [details] [review]
backend: Move out some code from post_init()

meta_backend_real_post_init() had some open coded initialization with
some unexpected interdependencies. Split these up and move them to their
own functions in order to make meta_backend_real_post_init() a bit more
readable.

Created attachment 351026 [details] [review]
input-settings: Minor structural cleanup

Let the backend implementations create their own input settings
backend, as is done with other backend specific special purpose
backends. Also use the macro for declaring the GType.

Created attachment 351027 [details] [review]
backend: Couple of whitespace fixes

Comment on attachment 351025 [details] [review]
backend: Move out some code from post_init()

Looks good!

Review of attachment 351026 [details] [review]:

Makes sense indeed. Just one nit.

::: src/backends/x11/meta-backend-x11.c
@@ +456,3 @@
+meta_backend_x11_create_input_settings (MetaBackend *backend)
+{
+  return g_object_new (META_TYPE_INPUT_SETTINGS_X11, NULL);

The older code didn't create a MetaInputSettings in the case running a nested compositor. We probably should be doing the same, as the nested compositor does not "own" the XI2 device properties.

Comment on attachment 351027 [details] [review]
backend: Couple of whitespace fixes

LGTM

(In reply to Carlos Garnacho from comment #5)
> Review of attachment 351026 [details] [review] [review]:
> 
> Makes sense indeed. Just one nit.
> 
> ::: src/backends/x11/meta-backend-x11.c
> @@ +456,3 @@
> +meta_backend_x11_create_input_settings (MetaBackend *backend)
> +{
> +  return g_object_new (META_TYPE_INPUT_SETTINGS_X11, NULL);
> 
> The older code didn't create a MetaInputSettings in the case running a
> nested compositor. We probably should be doing the same, as the nested
> compositor does not "own" the XI2 device properties.

True. I'll move it to the CM X11 backend.

Attachment 351025 [details] pushed as 755755a - backend: Move out some code from post_init()
Attachment 351026 [details] pushed as 81e99c2 - input-settings: Minor structural cleanup
Attachment 351027 [details] pushed as efc1907 - backend: Couple of whitespace fixes