GNOME Bugzilla – Bug 782145
[PATCH] Move GXml configuration from Autotools to Meson
Last modified: 2017-05-18 23:56:55 UTC
Created attachment 351016 [details] [review]
[PATCH] Porting project from Autotools to Meson.
With this patch, we can configure GXml project with Meson. (without tests, for the moment)
Review of attachment 351016 [details] [review]:
Please try not to touch Autotools at all. But is required, consider the following:
I found usefull to have a gxml.pc file to create a gxm-$API_VERSION.pc one, so use in configure.ac:
while you need a gxml/gxml.pc.in
For gxml.deps, use same approach. Create a gxml/gxml.deps files with actual content, don't create it in Makefile.am and in configure.ac use:
I don't see what is the use of PCDEPS in configure.ac, try to avoid it, it appears to be used only in menson build system.
While I'll try to test your implementation, because it should work without autotools, I haven't done yet.
I found meson build fails at:
gxml/meson.build line 117, with something about custome directory.
I've library target, removing all install_dir. I'm sure this is not the correct way, but works at least to compile. Now I have:
gxml = library('gxml-@0@'.format(API_VERSION),
version : GXML_VERSION,
vala_header : 'gxml.h',
vala_vapi : 'gxml-@0@.vapi'.format(API_VERSION),
vala_gir : 'GXml-@0@.gir'.format(API_VERSION),
dependencies : [ gee, gio, xml ],
vala_args : [
'--vapidir=' + meson.source_root() + '/vapi',
c_args : [
meson.current_build_dir() + '/config.h',
install : true)
Could you review your code. I'm using meson 0.37.1.
I'm pushing your work in a local branch. Once you provide a working patch, I'll push to master.
I've upgraded to meson 0.40.1, no error on gxml/meson.build, but missing po/meson.build, have you missed to include it in your patch?
I've pushed your work to repository. Made some additional changes and would like to see if i18n can be ported to Meson too.
I keep this bug open, because we need to check if ported has been successfully accomplished.
Seems no work remain and now GXml has been ported to Meson.
Thanks for your work.