After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782140 - adaptivedemux: handle segment seeks
adaptivedemux: handle segment seeks
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 782139 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-05-03 22:06 UTC by Mathieu Duponchelle
Modified: 2018-11-03 14:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dashdemux: reject segment seeks (988 bytes, patch)
2017-05-03 22:06 UTC, Mathieu Duponchelle 		rejected Details | Review

Description Mathieu Duponchelle 2017-05-03 22:06:32 UTC 
Currently the seeking request with GST_SEEK_FLAG_SEGMENT succeeds, but
the demuxer ends up sending out EOS anyway.
Comment 1 Mathieu Duponchelle 2017-05-03 22:06:35 UTC 
Created attachment 351013 [details] [review]
dashdemux: reject segment seeks
Comment 2 Edward Hervey 2017-05-04 05:58:41 UTC 
Shouldn't that patch be in adaptivedemux instead ?
Comment 3 Mathieu Duponchelle 2017-05-04 15:08:51 UTC 
Good question, I wasn't sure whether segment seeks would be implemented on a per-demuxer basis or generically in adaptivedemux, any idea ?
Comment 4 Edward Hervey 2017-05-05 05:48:59 UTC 
Most of the seek handling is done in the base class. Furthermore, the (non-segment) range handling is also done there (i.e. checking whether we've reached the requested stop position).

AFAICS, this would just require:
1) Not sending EOS when we've reached the stop (or start in reverse) position
2) When all download loops are done, post the SEGMENT_DONE message
Comment 5 Mathieu Duponchelle 2017-05-07 15:42:41 UTC 
Heh, I'm not opposed to actually implementing segment seeks, I just wasn't sure what this actually involved, if you say that can be done in the base class in a simple way I'll definitely have a quick try.
Comment 6 Sebastian Dröge (slomo) 2017-05-09 12:43:51 UTC 
*** Bug 782139 has been marked as a duplicate of this bug. ***
Comment 7 Mathieu Duponchelle 2017-07-07 15:40:20 UTC 
Review of attachment 351013 [details] [review]:

See https://bugzilla.gnome.org/show_bug.cgi?id=784655
Comment 8 GStreamer system administrator 2018-11-03 14:08:15 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/554.