After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782119 - meson: ext/hls/libgsthls.so needs -lm
meson: ext/hls/libgsthls.so needs -lm
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other FreeBSD
: Normal normal
: 1.12.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-03 13:12 UTC by Ting-Wei Lan
Modified: 2017-05-03 13:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
meson: hls: libm is required because m3u8.c uses math.h (822 bytes, patch)
2017-05-03 13:15 UTC, Ting-Wei Lan
committed Details | Review

Description Ting-Wei Lan 2017-05-03 13:12:52 UTC
gst-plugins-bad cannot be built with meson. ext/hls/m3u8.c uses functions declared in math.h, but libm is not listed as dependencies in meson.build.

FAILED: ext/hls/libgsthls.so 
clang  -o ext/hls/libgsthls.so 'ext/hls/gsthls@sha/gsthlsdemux.c.o' 'ext/hls/gsthls@sha/gsthlsdemux-util.c.o' 'ext/hls/gsthls@sha/gsthlsplugin.c.o' 'ext/hls/gsthls@sha/gsthlssink.c.o' 'ext/hls/gsthls@sha/gstm3u8playlist.c.o' 'ext/hls/gsthls@sha/m3u8.c.o' '-L/home/lantw44/gnome/devinstall/lib' '-L/usr/local/lib' '-Wl,--no-undefined' '-Wl,--as-needed' '-shared' '-fPIC' '-Wl,-soname,libgsthls.so' '-march=corei7' '-B/home/lantw44/.local/bin' '-pipe' '-g3' '-O1' 'gst-libs/gst/adaptivedemux/libgstadaptivedemux-1.0.so.0.1191.0' 'gst-libs/gst/uridownloader/libgsturidownloader-1.0.so.0.1191.0' 'gst-libs/gst/uridownloader/libgsturidownloader-1.0.so.0.1191.0' 'gst-libs/gst/uridownloader/libgsturidownloader-1.0.so.0.1191.0' '-lgstpbutils-1.0' '-lgstreamer-1.0' '-lgobject-2.0' '-lglib-2.0' '-lintl' '-lgsttag-1.0' '-lgstreamer-1.0' '-lgobject-2.0' '-lglib-2.0' '-lintl' '-lgstvideo-1.0' '-lgstbase-1.0' '-lgstreamer-1.0' '-lgobject-2.0' '-lglib-2.0' '-lintl' '-lgstbase-1.0' '-lgstreamer-1.0' '-lgobject-2.0' '-lglib-2.0' '-lintl' '-lgstbase-1.0' '-lgstreamer-1.0' '-lgobject-2.0' '-lglib-2.0' '-lintl' '-lgstbase-1.0' '-lgstreamer-1.0' '-lgobject-2.0' '-lglib-2.0' '-lintl' '-lnettle' '-Wl,-rpath,/home/lantw44/gnome/build/gst-plugins-bad/ext/hls:/home/lantw44/gnome/build/gst-plugins-bad/gst-libs/gst/adaptivedemux:/home/lantw44/gnome/build/gst-plugins-bad/gst-libs/gst/uridownloader'  
ext/hls/gsthls@sha/m3u8.c.o: In function `double_from_string':
/home/lantw44/gnome/build/gst-plugins-bad/../../source/gst-plugins-bad/ext/hls/m3u8.c:225: undefined reference to `__isfinite'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Comment 1 Ting-Wei Lan 2017-05-03 13:15:45 UTC
Created attachment 350977 [details] [review]
meson: hls: libm is required because m3u8.c uses math.h
Comment 2 Tim-Philipp Müller 2017-05-03 13:20:06 UTC
Thanks for the patch, pushed:

commit b5abaabeae20379d8043d55a5dd9d4328a439889
Author: Ting-Wei Lan <lantw@src.gnome.org>
Date:   Wed May 3 21:13:38 2017 +0800

    meson: hls: libm is required because m3u8.c uses math.h
    
    https://bugzilla.gnome.org/show_bug.cgi?id=782119