After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782085 - Gtk4 API rename gtk_accel_group_connect gtk_accel_group_connect_key
Gtk4 API rename gtk_accel_group_connect gtk_accel_group_connect_key
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: .General
3.90.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-05-02 19:51 UTC by infirit
Modified: 2018-05-02 18:26 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description infirit 2017-05-02 19:51:49 UTC
While working on some AccelGroup code in python I found that gtk_accel_group_connect conflicts in the binding with g_signal_connect. So instead of connecting signals AccelGroup.connect connects the keys instead. In PyGtk they actually ran into the same problem and decided to rename it in the bindings [1]

The workaround is easy but it would be nice if we can change this for Gtk4 it breaks API anyway. I was thinking of to rename is to gtk_accel_group_connect_key and gtk_accel_group_connect_key_by_path or something similar. Same rename of course for the related disconnect functions.

Based on some quick discussion on python-hackers [2] opening a bug to request the rename for Gtk4.

[1] http://www.pygtk.org/pygtk2reference/class-gtkaccelgroup.html#method-gtkaccelgroup--connect-group
[2] https://mail.gnome.org/archives/python-hackers-list/2017-May/msg00001.html
Comment 1 GNOME Infrastructure Team 2018-05-02 18:26:21 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/813.