After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782079 - list view column chooser dialog, list off center when description label is long (as in the italian translation)
list view column chooser dialog, list off center when description label is lo...
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.24.x
Other Linux
: Normal normal
: 3.26
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-02 16:00 UTC by Lapo Calamandrei
Modified: 2017-08-17 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot of the column chooser dialog, hilighting the issue. (27.48 KB, image/png)
2017-05-02 16:00 UTC, Lapo Calamandrei 		  Details
Patch to stop setting multiple margins on the column picker (919 bytes, patch)
2017-05-17 08:58 UTC, Robert Mibus 		none Details | Review
Patch to stop setting multiple margins on the column picker (930 bytes, patch)
2017-05-18 08:21 UTC, Robert Mibus 		committed Details | Review

Description Lapo Calamandrei 2017-05-02 16:00:10 UTC 
Created attachment 350893 [details]
Screenshot of the column chooser dialog, hilighting the issue.

In the italian translation the list of columns in the aformentioned dialog is off center. See the screenshot.
Comment 1 Robert Mibus 2017-05-17 08:58:44 UTC 
Created attachment 352007 [details] [review]
Patch to stop setting multiple margins on the column picker

This patch removes an extra margin that was causing the widget to be off-center (in English, not just Italian).
Comment 2 Carlos Soriano 2017-05-18 07:36:33 UTC 
Review of attachment 352007 [details] [review]:

Ah nice catch!
The commit message is missing the file name that is affected, can you fix that?
Otherwise it looks good.
Comment 3 Robert Mibus 2017-05-18 08:21:54 UTC 
Created attachment 352075 [details] [review]
Patch to stop setting multiple margins on the column picker

Replacement patch, with an improved comment (now includes the notable part of the file name being patched, like other recent commits do).
Comment 4 Carlos Soriano 2017-05-18 13:27:36 UTC 
Review of attachment 352075 [details] [review]:

Now looks good, thanks!