After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782047 - region: don't leak container
region: don't leak container
Product: gnome-control-center
Classification: Core
Component: Region & Language
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Reported: 2017-05-02 06:07 UTC by Mohammed Sadiq
Modified: 2017-05-02 10:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

region: don't leak container (911 bytes, patch)
2017-05-02 06:07 UTC, Mohammed Sadiq
none Details | Review
region: Fix memory leak (906 bytes, patch)
2017-05-02 10:33 UTC, Mohammed Sadiq
committed Details | Review

Description Mohammed Sadiq 2017-05-02 06:07:33 UTC
Comment 1 Mohammed Sadiq 2017-05-02 06:07:43 UTC
Created attachment 350843 [details] [review]
region: don't leak container

The returned result of g_variant_get_strv has to be freed
when no-longer needed
Comment 2 Bastien Nocera 2017-05-02 09:16:23 UTC
Review of attachment 350843 [details] [review]:

You should add that explanation to the commit message in bug 782048. But same problem as this bug for the commit subject.
Comment 3 Mohammed Sadiq 2017-05-02 10:33:55 UTC
Created attachment 350859 [details] [review]
region: Fix memory leak

The returned result of g_variant_get_strv has to be freed
when no-longer needed
Comment 4 Bastien Nocera 2017-05-02 10:37:20 UTC
Review of attachment 350859 [details] [review]:

> g_variant_get_strv


Otherwise looks great!
Comment 5 Bastien Nocera 2017-05-02 10:56:58 UTC
Attachment 350859 [details] pushed as aebf04f - region: Fix memory leak