GNOME Bugzilla – Bug 782023
toggle-pixbuf-renderer: Use gtk_render_activity, not gtk_paint_spinner
Last modified: 2017-09-07 09:56:07 UTC
gtk_pain_spinner has been deprecated in favour of gtk_render_activity. Unlike the former, the latter doesn't accept a 'step' argument, but that is probably fine because GdTogglePixbufRenderer:pulse is meant to show a spinner for any non-zero value. Got to ensure that this doesn't break gnome-boxes because it uses the spinner.
Created attachment 350819 [details] [review] toggle-pixbuf-renderer: Use gtk_render_activity, not gtk_paint_spinner
Review of attachment 350819 [details] [review]: Sure
Review of attachment 350819 [details] [review]: I tried this with gnome-boxes' express installation, and the spinner doesn't actually spin. It doesn't matter if I use gtk_style_context_set_state to set the GTK_STATE_FLAG_CHECKED flag. We might be out of luck since GtkCellRendererSpinner has also kept using gtk_paint_spinner.
Created attachment 351473 [details] [review] toggle-pixbuf-renderer: Ignore deprecation warnings
Review of attachment 351473 [details] [review]: OK then
Review of attachment 350819 [details] [review]: Marking as rejected
Comment on attachment 351473 [details] [review] toggle-pixbuf-renderer: Ignore deprecation warnings Thanks Cosimo!
(In reply to Debarshi Ray from comment #3) > Review of attachment 350819 [details] [review] [review]: > > I tried this with gnome-boxes' express installation, and the spinner doesn't > actually spin. It doesn't matter if I use gtk_style_context_set_state to set > the GTK_STATE_FLAG_CHECKED flag. We might be out of luck since > GtkCellRendererSpinner has also kept using gtk_paint_spinner. Bug 782396 has some discussion on that.