GNOME Bugzilla – Bug 782016
Add "reported OS" option NetworkManager openconnect cli+ui
Last modified: 2017-07-07 09:20:38 UTC
Created attachment 350808 [details] patch for master branch The attached patch implements (by analogy to other options) the "Reported OS" option in the UI. This option is sometimes necessary to be able to connect to VPN from Linux systems. It is the same as using "--os=" with openconnect CLI.
Created attachment 350809 [details] [review] patch for 1.2.4 release (current stable in Arch Linux)
Created attachment 350810 [details] [review] patch for master branch
The patch for 1.2.4 is tested and works for me on Arch Linux. Dear mainteiners, please discuss / verify / merge.
Anyone alive in NetworkManager maintainers team?
lgtm. On a minor note: a patch created with `git format-patch` contains already the proper author and commit message. What exact spelling for author would you prefer? (possibly in common "Firstname Lastname <email@host.tld>" form).
Looks good to me too.
@Thomas Haller Understood, will try using that command further on, thank you. Dmitrii Sutiagin <f3flight@gmail.com>
Any plans to merge?
(In reply to Dmitry from comment #8) > Any plans to merge? Yes. The patch was forgotten. Thanks for pinging. merged now to master: https://git.gnome.org/browse/network-manager-openconnect/commit/?id=9fbe2817da437f473cf46205e19c38d273adc600 Thanks!!
+ <property name="text" translatable="yes"/> This doesn’t look correct. What is translatable here?
(In reply to Piotr Drąg from comment #10) > + <property name="text" translatable="yes"/> > > This doesn’t look correct. What is translatable here? I don't know (not familiar with GTK). But this comment applies to other places as well ( https://git.gnome.org/browse/network-manager-openconnect/tree/properties/nm-openconnect-dialog.ui?id=9fbe2817da437f473cf46205e19c38d273adc600 )
Filed bug #784286.
Created attachment 355047 [details] [review] Add tooltip with suggestions for accepted reported OS values Hi, thanks for this patch, tested on Debian 9 and it works great. OpenConnect does strict validation on the --os option, so this small patch adds a tooltip with the currently accepted values as suggestion, to help the users. Otherwise it's easy to enter an invalid string and have the connection fail.
(In reply to Luca Boccassi from comment #13) > Created attachment 355047 [details] [review] [review] > Add tooltip with suggestions for accepted reported OS values thanks!! Merged: https://git.gnome.org/browse/network-manager-openconnect/commit/?id=d8242da3420812b13455cfdb62d2734dece632d4