GNOME Bugzilla – Bug 781988
Missing format symbols under "format cells"
Last modified: 2017-07-04 13:59:55 UTC
When I select "format cells" and go to "border", all of the expected options are there, but on the right side of the panel under "Style:" where the heavier lines and double line etc are displayed, I'm no longer seeing any of the symbols, just a small terminal symbol in each of the spaces, except "None" which displays correctly.
Jean, I understood you see this too -- could you have a look, please?
Yes, I'm seeing it, but I don't understand what's going on.
For me the lines are all there but on the left side there is a horizontal row of 5 buttons (assuming a cell selection with more than one row and column), the first one is no borders at all, the second one is outline on the very outside, etc.: The third and 5th symbol is missing but is just showing a terminal symbol with a red circle having a red diagonal line.
If it helps, I see the same problem as reporter. The line style images are failing to load into the buttons, though clicking a line style button works as expected. (Tested with Gnumeric 1.12.32 - the latest version in the Ubuntu repository)
Made some exploration. The culprit seems to be GdkPixbuf which is not anymore able to load pixdata (I don't know why). Removing the preprocess='to-pixdata' properties in gnm.gresource.xml seems to fix the issue.
gtk+ is still using to-pixdata for whatever that is worth: tests/resources.gresource.xml: <file preprocess="to-pixdata" alias="icc-profile.pixdata">icc-profile.png</file> tests/resources.gresource.xml: <file preprocess="to-pixdata" compressed="true" alias="icc-profile-compressed.pixdata">icc-profile.png</file> I don't find anything about it being deprecated.
It does not work the way we use it in the format dialog. I don't know how it works in other situations.
Created attachment 354813 [details] [review] Proposed patch
Do we understand that patch? I.e., is there a known problem with gtk_image_new_from_resource? Other than that, perhaps add a comment and commit.
There is another related bug: #781583. I added a comment there.
The same issue occurs at wbc-gtk.c:695 but a comment says that this code is currently unreachable. So may be we don't need to change it.
Review of attachment 354813 [details] [review]: Patch committed with a comment.
Patch not pushed yet.
This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.
Created attachment 354866 [details] screen shot This did not do it. At least I am still missing symbols in that dialog: see attached screenshot.
Looks like hyphen and underscore are not anymore equivalent in ui files. Quite a different issue actually.
We have multiple users of gtk_image_new_from_resource. We might need to create a gnm_image_new_from_resource to hide the issue. dialogs/dialog-printer-setup.c: state->icon_rd = gtk_image_new_from_resource ("/org/gnumeric/gnumeric/images/right-down.png"); dialogs/dialog-printer-setup.c: state->icon_dr = gtk_image_new_from_resource ("/org/gnumeric/gnumeric/images/down-right.png"); io-context-gtk.c: gtk_box_pack_start (box, gtk_image_new_from_resource ("/org/gnumeric/gnumeric/images/gnumeric_splash_1.4.png"), wbc-gtk.c: image = gtk_image_new_from_resource ("/org/gnumeric/gnumeric/images/sheet_move_marker.xpm");
Only images stored as pixdata c an issue
Oops! I was writing that only images stored as pixdata ar an issue, and this excludes icons for which things do work. The only other potential issue concerns sheet_move_marker.xpm which is not used in any reachable code.