After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781897 - Return key in Comment window isn't saved
Return key in Comment window isn't saved
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: metadata
0.26.x
Other Linux
: Normal minor
: 0.28
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-28 13:20 UTC by arverne
Modified: 2017-05-07 13:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screens (36.74 KB, application/pdf)
2017-04-28 13:20 UTC, arverne
  Details
window Preference metadata (56.61 KB, image/png)
2017-04-28 16:47 UTC, arverne
  Details
Do not strip newlines from comments on write-back (1.29 KB, patch)
2017-05-01 16:33 UTC, Jens Georg
committed Details | Review

Description arverne 2017-04-28 13:20:16 UTC
Created attachment 350641 [details]
Screens

When you add a comment to a photo (Menu Photos / Edit the comment...), if you type different lines (paragraph) separated with the Return key, it is not saved.
When you open it again, all the sentences (paragraph) are one after another.
Comment 1 Jens Georg 2017-04-28 13:56:38 UTC
Do you have automatic meta-data saving to image enabled or disabled?
Comment 2 arverne 2017-04-28 16:47:10 UTC
Created attachment 350673 [details]
window Preference metadata
Comment 3 arverne 2017-04-28 16:47:46 UTC
Yes it is enabled (see attachment)
Comment 4 Jens Georg 2017-04-28 19:29:45 UTC
Thanks. Maybe something is broken when reading things back, I will check. Thank you for your effort.
Comment 5 arverne 2017-04-28 20:00:24 UTC
Thanks to you to take care of this useful soft !
I have prepared the french translation of the 0.26 but, at the moment, no answer of the french translation list... I continue
Comment 6 Jens Georg 2017-05-01 15:22:45 UTC
You're welcome. I can confirm this happens when the data is written back to the file and then updated. It loses the newlines.
Comment 7 Jens Georg 2017-05-01 16:17:07 UTC
So when shotwell is writing tags to the image, it is stripping newlines from the strings to avoid having titles etc. with line breaks, but that's probably overshooting for comments.
Comment 8 Jens Georg 2017-05-01 16:33:09 UTC
Created attachment 350807 [details] [review]
Do not strip newlines from comments on write-back

Stripping newlines makes sense for titles etc, but it makes sense to keep them
for comments.
Comment 9 Jens Georg 2017-05-07 13:58:08 UTC
Attachment 350807 [details] pushed as e00379b - Do not strip newlines from comments on write-back