After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781896 - Wayland: Make key repeat more resilient to keys not being released
Wayland: Make key repeat more resilient to keys not being released
Status: RESOLVED DUPLICATE of bug 781285
Product: gtk+
Classification: Platform
Component: Backend: Wayland
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-04-28 12:35 UTC by Olivier Fourdan
Modified: 2017-05-04 09:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Wayland: Cancel repeat only on last key press (2.61 KB, patch)
2017-04-28 12:45 UTC, Olivier Fourdan
none Details | Review

Description Olivier Fourdan 2017-04-28 12:35:42 UTC
Description:

Bug 778019 (and bug 779374) changed the way key repeat is handled, allowing more than one key press and still repeat the last key pressed when the previous one is released.

Unfortunately, if there is one key release missing (e.g. keyboard hardware issue keeping a key depressed), all keys will be repeated indefinitely.

Steps to reproduce:

1. Press key "a" and keep the key pressed
2. Press key "b" and release.
3. Press key "c" and release.

Actual result:

Key "b" is repeated even after being released, until key "c" is pressed, and then key "c" is preated even after it's released, etc.

Expected result:

If the last key press is released, key repeat should stop even if some older key is kept depressed.

Additional data:

See https://bugzilla.redhat.com/show_bug.cgi?id=1428280#c7 and later.
Comment 1 Olivier Fourdan 2017-04-28 12:45:47 UTC
Created attachment 350636 [details] [review]
[PATCH] Wayland: Cancel repeat only on last key press

When pressing multiple keys at once, the last key pressed gets repeated
even after release when an older key is kept depressed.

Pressing "a" then "b" and release "a" will repeat "b" until "a" is
released.

This can be problematic when a key release is not received (e.g. a
keyboard hardware issue that would keep a key pressed), every last key
press is repeated even after the key is released.

Make the Wayland backend more resilient to such possible issue by
stopping key repeat when the last key pressed is released (like Xorg
which doesn't have this issue).

https://bugzilla.gnome.org/show_bug.cgi?id=781896
Comment 2 Olivier Fourdan 2017-05-04 09:29:03 UTC

*** This bug has been marked as a duplicate of bug 781285 ***