After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781882 - Bring back fancy error reporter in gjs-console
Bring back fancy error reporter in gjs-console
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2017-04-28 07:06 UTC by Philip Chimento
Modified: 2017-04-29 04:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
modules/console: Bring back fancy error reporter (1.17 KB, patch)
2017-04-28 07:11 UTC, Philip Chimento 		committed Details | Review
modules/console: Update fancy error reporter to mozjs38 (3.89 KB, patch)
2017-04-28 07:11 UTC, Philip Chimento 		committed Details | Review

Description Philip Chimento 2017-04-28 07:06:03 UTC 
At some point we lost our custom error reporter from gjs-console. It doesn't compile with SpiderMonkey 45 and so will have to be changed, but I noticed it was never being called. Instead of removing it, let's restore it.
Comment 1 Philip Chimento 2017-04-28 07:11:15 UTC 
Created attachment 350617 [details] [review]
modules/console: Bring back fancy error reporter

At some point we lost our custom error reporter from gjs-console. It
doesn't compile with SpiderMonkey 45 and so will have to be changed, but
I noticed it was never being called. Instead of removing it, let's
restore it.
Comment 2 Philip Chimento 2017-04-28 07:11:19 UTC 
Created attachment 350618 [details] [review]
modules/console: Update fancy error reporter to mozjs38

It turns out the error reporter was copied almost verbatim from an
internal SpiderMonkey function, js::PrintError(). By copying in a newer
version from SpiderMonkey 38, we get the latest improvements: along with
the line number, the character column of the error is also printed.
Comment 3 Cosimo Cecchi 2017-04-28 17:46:46 UTC 
Review of attachment 350617 [details] [review]:

OK
Comment 4 Cosimo Cecchi 2017-04-28 17:47:32 UTC 
Review of attachment 350618 [details] [review]:

Sure
Comment 5 Philip Chimento 2017-04-29 04:02:52 UTC 
Attachment 350617 [details] pushed as 1884a52 - modules/console: Bring back fancy error reporter
Attachment 350618 [details] pushed as 854a2bc - modules/console: Update fancy error reporter to mozjs38