After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781846 - Fails to build
Fails to build
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Wacom
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: Carlos Garnacho
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-27 16:10 UTC by Alberts Muktupāvels
Modified: 2017-04-27 17:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
common: Add "pad" GsdDeviceType to GsdDeviceManager (987 bytes, patch)
2017-04-27 16:59 UTC, Bastien Nocera 		committed Details | Review

Description Alberts Muktupāvels 2017-04-27 16:10:50 UTC 
I tried to build GNOME 3.22 with JHBuild and gnome-control-center now fails to build.

gsd-device-manager-x11.c: In function ‘device_get_device_type’:
gsd-device-manager-x11.c:61:36: error: ‘GSD_DEVICE_TYPE_PAD’ undeclared (first use in this function)
    return GSD_DEVICE_TYPE_TABLET | GSD_DEVICE_TYPE_PAD;
Comment 1 Bastien Nocera 2017-04-27 16:22:52 UTC 
(In reply to Alberts Muktupāvels from comment #0)
> I tried to build GNOME 3.22 with JHBuild and gnome-control-center now fails
> to build.
> 
> gsd-device-manager-x11.c: In function ‘device_get_device_type’:
> gsd-device-manager-x11.c:61:36: error: ‘GSD_DEVICE_TYPE_PAD’ undeclared
> (first use in this function)
>     return GSD_DEVICE_TYPE_TABLET | GSD_DEVICE_TYPE_PAD;

Regression introduced by:
commit 30e262fd220eb85bcaa7bb00bd251df1b7598489
Author: Carlos Garnacho <carlosg@gnome.org>
Date:   Tue Nov 1 12:44:21 2016 +0100

    common: Handle pad devices in GsdDeviceManagerX11
    
    We cater for the old(=Wacom) and new(=libinput) type/name schemes,
    so we don't require a too recent gtk+ just for this.
Comment 2 Bastien Nocera 2017-04-27 16:59:25 UTC 
Created attachment 350564 [details] [review]
common: Add "pad" GsdDeviceType to GsdDeviceManager

So we can recognize pad devices.

Note:
  Cherry-picked from master commit 176dfca to fix
Comment 3 Rui Matos 2017-04-27 17:06:40 UTC 
Review of attachment 350564 [details] [review]:

Yeah, I forgot to cherry-pick this one too, sorry.
Comment 4 Bastien Nocera 2017-04-27 17:43:22 UTC 
Attachment 350564 [details] pushed as 18e67c6 - common: Add "pad" GsdDeviceType to GsdDeviceManager