GNOME Bugzilla – Bug 781828
location: Don't release libxml-allocated memory with g_free()
Last modified: 2017-06-28 17:57:42 UTC
See patch.
Created attachment 350543 [details] [review] location: Don't release libxml-allocated memory with g_free() Don't assume that xmlFree() and g_free() are interchangeable, copy the value returned from XML like we already do for other struct members.
Downstream (Fedora) reporters are reporting running into another crash, with the Fedora build that's supposed to fix this bug and http://bugzilla.gnome.org/show_bug.cgi?id=780278 : https://bugzilla.redhat.com/show_bug.cgi?id=1446879 There is a traceback in that report: https://bugzilla.redhat.com/attachment.cgi?id=1275243
*** Bug 782460 has been marked as a duplicate of this bug. ***
Ah, I had missed this one from 3.24.1. I believe there is no functional change (until libxml or glib change memory allocator) but the patch makes sense so I applied it. Attachment 350543 [details] pushed as 9b08eea - location: Don't release libxml-allocated memory with g_free()
Seeing it has been a while, it fixes a crasher and no new releases planned: Maybe do another libgweather release? This to ensure all distributions get the gnome-shell crash fix.
This actually fixes nothing, because xmlFree and g_free are interchangable (they both just call free()), unless some unusual build flags are applied. The crashers that were seen around the time of this bug were unrelated and fixed in 3.24.1 Nevertheless, if you want I can make a 3.24.2. It would have only this patch though, not even translation updates are queued.