After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781806 - Modernize shell scripts
Modernize shell scripts
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2017-04-26 23:02 UTC by Claudio André
Modified: 2017-04-28 05:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Travis related script (1.63 KB, patch)
2017-04-26 23:05 UTC, Claudio André 		committed Details | Review
Tests related script (4.32 KB, patch)
2017-04-26 23:06 UTC, Claudio André 		committed Details | Review

Description Claudio André 2017-04-26 23:02:36 UTC 
I used a static analysis tool in order to identify any "weakness" in all GJS shell scripts.

- There is a rationale behind each change, we can discuss any of it;
- It is expected to work fine in other shells (I mean, not bash);
- I'll attach 2 patches because one is 100% tied to Travis; once it works there, we are done; the other patch handles GJS tests;
- all succeeded on CI;
- It is not a bad thing, but I'm not sure you guys want it.
Comment 1 Claudio André 2017-04-26 23:05:06 UTC 
Created attachment 350516 [details] [review]
Travis related script
Comment 2 Claudio André 2017-04-26 23:06:17 UTC 
Created attachment 350517 [details] [review]
Tests related script
Comment 3 Philip Chimento 2017-04-28 05:54:26 UTC 
Review of attachment 350517 [details] [review]:

This is great, thanks! +1
Comment 4 Philip Chimento 2017-04-28 05:55:41 UTC 
Review of attachment 350516 [details] [review]:

+1 This is also great, but since we unfortunately still haven't gotten Travis enabled on the GNOME Github mirror I can't test it. I'll trust that it works for you :-)