After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781793 - dconf defaults: Restore session-name override
dconf defaults: Restore session-name override
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal major
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-26 19:24 UTC by Jeremy Bicha
Modified: 2017-05-02 13:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
dconf defaults: Restore session-name override (844 bytes, patch)
2017-04-26 19:24 UTC, Jeremy Bicha
committed Details | Review

Description Jeremy Bicha 2017-04-26 19:24:28 UTC
Ubuntu 16.04 LTS - 17.04
gdm 3.18.3 - 3.24.1

Test Case
---------
A user of default Ubuntu (running Unity) installs gnome-shell without installing the ubuntu-gnome-desktop metapackage. gnome-shell installs gdm. The user is asked whether to use gdm or lightdm. If the user picks gdm, the login screen will fail to load after the computer is restarted.

Ubuntu's default install includes the ubuntu-settings package which contains
/usr/share/glib-2.0/10_ubuntu-settings.gchema.override

That file contains:
[org.gnome.desktop.session]
session-name="ubuntu"

Other Info
----------
Ubuntu GNOME sets session-name="gnome"

This is a partial revert of https://git.gnome.org/browse/gdm/commit/data/?id=f66cdfcb
Comment 1 Jeremy Bicha 2017-04-26 19:24:31 UTC
Created attachment 350502 [details] [review]
dconf defaults: Restore session-name override

This was dropped in f66cdfcb but GDM won't start when the
default session-name is set to something else
Comment 2 Ray Strode [halfline] 2017-04-26 19:37:39 UTC
Review of attachment 350502 [details] [review]:

okay sounds fine.
I wonder if we should revert commit 9fb36b5bef44bfe4aa1dda52196e08480638ce35 too
Comment 3 Jeremy Bicha 2017-04-26 19:47:20 UTC
Attachment 350502 [details] pushed as ec240a6 - dconf defaults: Restore session-name override
Comment 4 Jeremy Bicha 2017-05-02 13:01:12 UTC
(In reply to Ray Strode [halfline] from comment #2)
> I wonder if we should revert commit 9fb36b5bef44bfe4aa1dda52196e08480638ce35

I don't know. Maybe?

Is it ok if I push my patch to the 3.22 and 3.24 branches too?