Review of attachment 350498 [details] [review]:

Code looks good, the commit message doesn't follow the guidelines though. You can read them in the newcomers wiki

Created attachment 350504 [details] [review]
Patch v2

Fixed patch according to previous comment, should be good now. Sorry for the mistake

Review of attachment 350504 [details] [review]:

Heya, thansk for the update.
The commit message is still missing a description, did you read the guidelines we provide?

That's weird. I do remember the full description inside my commit, something must have gone wrong somehow. I'll update it again in a couple of hours.

did you use git format-patch -1? that should work
Make sure you are not in "rebase" or something (you are not if you don't know what is this :D)

No, I didn't rebase, I just amended the previous commit :)
I used gitg this time, but something was already not right because it wasn't able to grab name and email from its own configuration and I had to fix it myself in the patch.
I'll be back to git format-patch which I know better :D

Indeed, I forgot to mention seems there is a bug in gitg about that. :( so yeah, git format-patch, sorry!

Created attachment 350565 [details] [review]
Patch v3

(In reply to Carlos Soriano from comment #7)
> Indeed, I forgot to mention seems there is a bug in gitg about that. :( so
> yeah, git format-patch, sorry!

No worries :)
I've never struggle this much with a so easy patch :D
Hope this is fine ;)

Review of attachment 350565 [details] [review]:

now looks good, thanks for the patch!

Great! Thanks

Just for curiosity, what's the process to have it in master branch?

Thanks

Whops, the process is someone commiting it, but I forgot :)

Now is in master, congrats!!

:D thank you!