GNOME Bugzilla – Bug 781786
Add omxmp3dec config for Bellagio
Last modified: 2017-05-21 14:57:49 UTC
Created attachment 350497 [details] [review] patch Adds configuration for mp3 decoder
Thanks for the new configuration. May I ask why you're using Bellagio? The codecs in there are all software based and we have better native GStreamer elements for these libraries, and at the same time Bellagio also does not implement the OpenMAX IL spec correctly so is also not a good choice for conformance testing.
Gurkirpal tried Bellagio for testing/debugging purpose and to compare results with Tizonia. I am mentoring Gurkirpal for the GSoC project mentioned here https://bugzilla.gnome.org/show_bug.cgi?id=782800 . I will push attached patch (new Bellagio conf for mp3) during the hackfest this weekend if no objection.
Created attachment 352204 [details] [review] config: add omxmp3dec for Bellagio config I removed the 'local' in core-name path, see commit message for the reason. I think we should allow the user to just set the lib name if he wants, instead of requiring the full path name. At first glance it just requires to improve the check https://cgit.freedesktop.org/gstreamer/gst-omx/tree/omx/gstomx.c#n2765 . Thoughts ?
Comment on attachment 352204 [details] [review] config: add omxmp3dec for Bellagio config commit 29ce1d91529a4aebdff199999920a5def5f9c56f Author: Gurkirpal Singh <gurkirpal204@gmail.com> Date: Wed Apr 26 22:52:17 2017 +0530 config: add OMX.st.audio_decoder.mp3.mad for Bellagio config MP3 Software decoder (libmad based) but useful for testing and to compare with other targets. GST_OMX_CONFIG_DIR=$HOME/gst/master/gst-omx/config/bellagio/ \ gst-launch-1.0 filesrc location=mpthreetest.mp3 ! id3demux ! \ mpegaudioparse ! omxmp3dec ! audioconvert ! pulsesink Didn't add 'local' in core-name path compared to other components in that same gstomx.conf file because OMX.st.audio_decoder.mp3.mad comes with the Ubuntu package 'libomxil-bellagio0-components-mad'. All other components listed in this gstomx.conf for Bellagio, are not provided by any Ubuntu packages. It could explain the 'local', i.e. requiring to build them from source. dpkg -L libomxil-bellagio0 /usr/lib/libomxil-bellagio.so.0 https://bugzilla.gnome.org/show_bug.cgi?id=781786 Signed-off-by: Gurkirpal Singh <gurkirpal204@gmail.com> Signed-off-by: Julien Isorce <jisorce@oblong.com>