After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781786 - Add omxmp3dec config for Bellagio
Add omxmp3dec config for Bellagio
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
1.13.x
Other Linux
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-26 17:30 UTC by gurkirpal204
Modified: 2017-05-21 14:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (907 bytes, patch)
2017-04-26 17:30 UTC, gurkirpal204
none Details | Review
config: add omxmp3dec for Bellagio config (1.61 KB, patch)
2017-05-20 09:34 UTC, Julien Isorce
committed Details | Review

Description gurkirpal204 2017-04-26 17:30:26 UTC
Created attachment 350497 [details] [review]
patch

Adds configuration for mp3 decoder
Comment 1 Sebastian Dröge (slomo) 2017-04-27 09:27:25 UTC
Thanks for the new configuration. May I ask why you're using Bellagio? The codecs in there are all software based and we have better native GStreamer elements for these libraries, and at the same time Bellagio also does not implement the OpenMAX IL spec correctly so is also not a good choice for conformance testing.
Comment 2 Julien Isorce 2017-05-19 10:04:16 UTC
Gurkirpal tried Bellagio for testing/debugging purpose and to compare results with Tizonia. I am mentoring Gurkirpal for the GSoC project mentioned here https://bugzilla.gnome.org/show_bug.cgi?id=782800 . I will push attached patch (new Bellagio conf for mp3) during the hackfest this weekend if no objection.
Comment 3 Julien Isorce 2017-05-20 09:34:42 UTC
Created attachment 352204 [details] [review]
config: add omxmp3dec for Bellagio config

I removed the 'local' in core-name path, see commit message for the reason.

I think we should allow the user to just set the lib name if he wants, instead of requiring the full path name. At first glance it just requires to improve the check https://cgit.freedesktop.org/gstreamer/gst-omx/tree/omx/gstomx.c#n2765 . Thoughts ?
Comment 4 Julien Isorce 2017-05-21 14:44:10 UTC
Comment on attachment 352204 [details] [review]
config: add omxmp3dec for Bellagio config

commit 29ce1d91529a4aebdff199999920a5def5f9c56f
Author: Gurkirpal Singh <gurkirpal204@gmail.com>
Date:   Wed Apr 26 22:52:17 2017 +0530

    config: add OMX.st.audio_decoder.mp3.mad for Bellagio config
    
    MP3 Software decoder (libmad based) but useful for testing
    and to compare with other targets.
    
    GST_OMX_CONFIG_DIR=$HOME/gst/master/gst-omx/config/bellagio/ \
        gst-launch-1.0 filesrc location=mpthreetest.mp3 ! id3demux ! \
        mpegaudioparse ! omxmp3dec ! audioconvert ! pulsesink
    
    Didn't add 'local' in core-name path compared to other components
    in that same gstomx.conf file because OMX.st.audio_decoder.mp3.mad
    comes with the Ubuntu package 'libomxil-bellagio0-components-mad'.
    All other components listed in this gstomx.conf for Bellagio, are
    not provided by any Ubuntu packages. It could explain the 'local',
    i.e. requiring to build them from source.
    
    dpkg -L libomxil-bellagio0
        /usr/lib/libomxil-bellagio.so.0
    
    https://bugzilla.gnome.org/show_bug.cgi?id=781786
    
    Signed-off-by: Gurkirpal Singh <gurkirpal204@gmail.com>
    Signed-off-by: Julien Isorce <jisorce@oblong.com>