GNOME Bugzilla – Bug 781769
tests: Prefer ${NM} over `nm` in abicheck.sh
Last modified: 2018-09-21 16:21:50 UTC
Created attachment 350481 [details] [review] abicheck.sh: use ${NM} if provided, otherwise fall back to `nm` `nm` might not be the correct nm executable, especially when cross-compiling. The patches changes the behaviour to prefer ${NM} if it's provided and fall back to `nm` otherwise. I tried to do this the correct way by using A[CM]_PROG_NM / LT_PATH_NM, but that pulls in libtool and causes problems when linking the gsettings module. Therefore I went with just allowing to override it from the environment Best regards, Marvin
Review of attachment 350481 [details] [review]: dconf has since been ported to build using Meson rather than autotools. It should be possible to modify gsettings/meson.build to set the $NM environment variable when running abicheck.sh, according to whatever nm utility is configured in its cross-file (https://github.com/mesonbuild/meson/blob/master/docs/markdown/Cross-compilation.md). This is a step in the right direction towards that, though, so I’ll push this to master. Thanks.
Comment on attachment 350481 [details] [review] abicheck.sh: use ${NM} if provided, otherwise fall back to `nm` Pushed to master. Keeping the bug open to track linking this in with Meson's cross file.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/dconf/issues/36.