After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781672 - Remove gd_entry_focus_hack
Remove gd_entry_focus_hack
Status: RESOLVED FIXED
Product: libgd
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libgd maintainer(s)
libgd maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-04-24 18:27 UTC by Debarshi Ray
Modified: 2017-04-25 09:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove gd_entry_focus_hack (6.10 KB, patch)
2017-04-24 18:28 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2017-04-24 18:27:48 UTC 
gd_entry_focus_hack is not needed any more. Since gtk-3.16, one can use gtk_entry_grab_focus_without_selecting:
https://developer.gnome.org/gtk3/stable/GtkEntry.html#gtk-entry-grab-focus-without-selecting

gnome-documents already does that, and I believe other applications can/should do the same.

As a nice side-effect this gets rid of a whole bunch of warnings due to the deprecated GdkDeviceManager API from every application that needs the 'gtk-hacks' subset of libgd.
Comment 1 Debarshi Ray 2017-04-24 18:28:40 UTC 
Created attachment 350326 [details] [review]
Remove gd_entry_focus_hack
Comment 2 Cosimo Cecchi 2017-04-24 19:07:10 UTC 
Review of attachment 350326 [details] [review]:

Yes, I'm very happy to see this one go.