After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781653 - meson: delegate submodule initialization to Meson
meson: delegate submodule initialization to Meson
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on: 781650
Blocks:
 
 
Reported: 2017-04-24 07:46 UTC by Ernestas Kulik
Modified: 2017-04-25 08:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
meson: delegate submodule initialization to Meson (1.66 KB, patch)
2017-04-24 07:46 UTC, Ernestas Kulik
committed Details | Review

Description Ernestas Kulik 2017-04-24 07:46:38 UTC
As of 0.40.0, Meson has the ability to initialize subprojects that are
git submodules. This removes the need for a separate script to achieve
that.
Comment 1 Ernestas Kulik 2017-04-24 07:46:42 UTC
Created attachment 350284 [details] [review]
meson: delegate submodule initialization to Meson
Comment 2 Carlos Soriano 2017-04-24 08:41:06 UTC
Review of attachment 350284 [details] [review]:

:O these guys are good
Comment 3 Carlos Soriano 2017-04-24 13:34:35 UTC
Forgot to mention, we should make sure meson 0.40 is in the SDK before committing this.
Comment 4 Ernestas Kulik 2017-04-24 19:31:06 UTC
(In reply to Carlos Soriano from comment #3)
> Forgot to mention, we should make sure meson 0.40 is in the SDK before
> committing this.

Done and done: https://github.com/flatpak/freedesktop-sdk-images/commit/7d9f89b7f68671b4dd3932fd327f4f565067790b
Comment 5 Ernestas Kulik 2017-04-25 08:23:01 UTC
Attachment 350284 [details] pushed as 9948131 - meson: delegate submodule initialization to Meson