GNOME Bugzilla – Bug 781622
gtkplacesview.ui: Update helper label to include IPv6 addresses
Last modified: 2017-04-22 19:55:36 UTC
.
Created attachment 350249 [details] [review] gtkplacesview.ui: Update helper label to include IPv6 addresses This is a backport from 16bce171683d58. Thing is Nautilus pulled the code from master until now, so right now gtk-3-22 and Nautilus 3.24 differ. Would be great to have them share the same code, and at the same time have this small string helper issue fixed.
Forgot to mention, this is for 3.22
Review of attachment 350249 [details] [review]: tbh, marking this string as translatable seems entirely pointless
Created attachment 350250 [details] [review] gtkplacesview.ui: Remove translatable from server label helper Translating it seems pointless if we can use a non-translatable example such as gnome.org instead of foo.example.com. This will help to make changes in here without breaking string freeze.
Created attachment 350251 [details] [review] gtkplacesview.ui: Update helper label to include IPv6 addresses This is a backport from 16bce171683d58. Thing is Nautilus pulled the code from master until now, so right now gtk-3-22 and Nautilus 3.24 differ. Would be great to have them share the same code, and at the same time have this small string helper issue fixed.
Review of attachment 350250 [details] [review]: I agree
Review of attachment 350251 [details] [review]: ok
Created attachment 350252 [details] [review] gtkplacesview.ui: Remove translatable from server label helper Translating it seems pointless if we can use a non-translatable example such as gnome.org instead of foo.example.com. This will help to make changes in here without breaking string freeze.
Attachment 350252 [details] pushed as 72d1353 - gtkplacesview.ui: Remove translatable from server label helper