GNOME Bugzilla – Bug 781616
Missing license information
Last modified: 2017-05-10 15:24:25 UTC
There is no license information so far in Usage's code base. I personally would advocate to use GPLv3+, where we would prepend the following header to every code file: /* application.vala * * Copyright (C) 2017 Red Hat, Inc. * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program. If not, see <http://www.gnu.org/licenses/>. * * Authors: Petr Štětka <pstetka@redhat.com> * Felipe Borges <felipeborges@gnome.org> */ Updating the Authors list according to the developers that made significant contributions to the given source code file. Other than that, we should distribute at least a COPYING or LICENSE file containing the full text of the license. Thoughts?
I think we can add this header to every code file. However, the LICENSE file already exists, containing the full text of the GPLv3 license.
Created attachment 350484 [details] [review] Add license header to every code file
Created attachment 350487 [details] [review] Add license header to every code file
Review of attachment 350487 [details] [review]: Thanks for the patch! I don't think you should place me as an author in every single file. Just the ones that I wrote or did significant changes. Please rework this commit to add just your name and I will add my name in the files that I will touch from now on.
Created attachment 350972 [details] [review] Add license header to every code file
Review of attachment 350972 [details] [review]: This patch applies on top of your previous patch, not in the current code base.
Created attachment 351552 [details] [review] Add license header to every code file
Review of attachment 351552 [details] [review]: sure.
Review of attachment 351552 [details] [review]: Thanks! I pushed it as ca94063567c635c67d26c706102a0fb0fc6b9de6.
I close this bug as resolved.