After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781600 - Boxes should rely on libosinfo data in order to decide whether an installer media should be eject after installation or not
Boxes should rely on libosinfo data in order to decide whether an installer m...
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: installer
3.24.x
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-04-21 23:05 UTC by Fabiano Fidêncio
Modified: 2017-09-20 12:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
installer-media: Allow keeping the media after installation (1.65 KB, patch)
2017-04-21 23:08 UTC, Fabiano Fidêncio 		committed Details | Review
configure: Require libosinfo >= 1.1.0 (764 bytes, patch)
2017-09-13 10:30 UTC, Debarshi Ray 		committed Details | Review
build (meson): Require libosinfo >= 1.1.0 (1.01 KB, patch)
2017-09-20 12:47 UTC, Felipe Borges 		committed Details | Review

Description Fabiano Fidêncio 2017-04-21 23:05:10 UTC 
This new API has been pushed Today in libosinfo[0] and osinfo-db[1] and will be used in the coming soon patches adding support of express installation for SLES[2].

[0]: https://gitlab.com/libosinfo/libosinfo/commit/29f88aad24fdaea8ebb5c905de5dff9036e05f75
[1]: https://gitlab.com/libosinfo/osinfo-db/commit/545a7c3d3c8a3d975a4f4d83f6e0ef92f2a2c655
[2]: https://gitlab.com/fidencio/osinfo-db/commits/wip/sles

Please, see the attached patch.
Comment 1 Fabiano Fidêncio 2017-04-21 23:08:06 UTC 
Created attachment 350216 [details] [review]
installer-media: Allow keeping the media after installation
Comment 2 Felipe Borges 2017-05-04 08:31:19 UTC 
Review of attachment 350216 [details] [review]:

Sure. Since we spoke on IRC that this patch is dependent on a libosinfo release, I will leave the bug opened and you can feel free to push as soon as there's a release on your side.

For the record, it would be appreciated if you could link to the release here in the bug before we close it.
Comment 3 Felipe Borges 2017-09-12 10:25:40 UTC 
Review of attachment 350216 [details] [review]:

libosinfo 1.1.0 is out! See https://www.redhat.com/archives/libosinfo/2017-August/msg00032.html

Between other things, the changes in this release include:

- Support eject-after-install parameter in OsinfoMedia

This way we can finally land the patch above.

Thanks Fabiano!
Comment 4 Felipe Borges 2017-09-12 10:31:20 UTC 
Review of attachment 350216 [details] [review]:

pushed!
Comment 5 Debarshi Ray 2017-09-13 10:30:58 UTC 
Created attachment 359698 [details] [review]
configure: Require libosinfo >= 1.1.0
Comment 6 Felipe Borges 2017-09-13 11:02:57 UTC 
Review of attachment 359698 [details] [review]:

Great.

I have checked a few distros and the most popular ones already have libosinfo 1.1.0 builds targeting their next releases. So lgtm
Comment 7 Debarshi Ray 2017-09-13 11:11:29 UTC 
Comment on attachment 359698 [details] [review]
configure: Require libosinfo >= 1.1.0

Thanks. Pushed to master.
Comment 8 Felipe Borges 2017-09-20 12:47:16 UTC 
Created attachment 360127 [details] [review]
build (meson): Require libosinfo >= 1.1.0

Fallout from f4d14a7669c03ff34af383824044b2246230fc56
Comment 9 Felipe Borges 2017-09-20 12:48:06 UTC 
We were missing the meson build dependency bump.

Attachment 360127 [details] pushed as ebb403c - build (meson): Require libosinfo >= 1.1.0