After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781532 - Be more strict about invalid code paths
Be more strict about invalid code paths
Status: RESOLVED OBSOLETE
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-04-20 13:18 UTC by Debarshi Ray
Modified: 2021-07-05 11:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
selections: Be more strict about invalid code paths (893 bytes, patch)
2017-04-20 13:19 UTC, Debarshi Ray 		committed Details | Review
documents: Tie the catch blocks more tightly to the failure sites (4.01 KB, patch)
2017-04-20 13:20 UTC, Debarshi Ray 		committed Details | Review
documents: Be more strict about invalid code paths (2.02 KB, patch)
2017-04-20 13:21 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2017-04-20 13:18:13 UTC 
Certain errors are indicative of outright programming flaws, as opposed to something that can possibly fail at run-time. Let's be more strict about these by throwing an exception.

(The C equivalents would be to log a CRITICAL or abort with an assertion.)
Comment 1 Debarshi Ray 2017-04-20 13:19:29 UTC 
Created attachment 350123 [details] [review]
selections: Be more strict about invalid code paths
Comment 2 Debarshi Ray 2017-04-20 13:20:57 UTC 
Created attachment 350124 [details] [review]
documents: Tie the catch blocks more tightly to the failure sites
Comment 3 Debarshi Ray 2017-04-20 13:21:10 UTC 
Created attachment 350125 [details] [review]
documents: Be more strict about invalid code paths
Comment 4 Cosimo Cecchi 2017-04-20 16:18:26 UTC 
Review of attachment 350123 [details] [review]:

++
Comment 5 Cosimo Cecchi 2017-04-20 16:20:01 UTC 
Review of attachment 350124 [details] [review]:

Good idea
Comment 6 Cosimo Cecchi 2017-04-20 16:20:24 UTC 
Review of attachment 350125 [details] [review]:

++
Comment 7 GNOME Infrastructure Team 2021-07-05 11:31:30 UTC 
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/gnome-documents/-/issues/

Thank you for your understanding and your help.