After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781521 - Add a first version of Flatpak manifest
Add a first version of Flatpak manifest
Status: RESOLVED FIXED
Product: gnome-usage
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Usage maintainer(s)
GNOME Usage maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-04-20 10:08 UTC by Felipe Borges
Modified: 2017-04-20 14:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Do not include absolute paths (1.26 KB, patch)
2017-04-20 10:08 UTC, Felipe Borges
committed Details | Review
flatpak: Add org.gnome.Usage flatpak manifest (2.24 KB, patch)
2017-04-20 10:09 UTC, Felipe Borges
committed Details | Review
build: Compile GSchemas in post install (1.24 KB, patch)
2017-04-20 13:45 UTC, Felipe Borges
committed Details | Review

Description Felipe Borges 2017-04-20 10:08:32 UTC
.
Comment 1 Felipe Borges 2017-04-20 10:08:55 UTC
Created attachment 350109 [details] [review]
build: Do not include absolute paths

The meson.build file is including libgtop-2.0 from a absolute
path. This is not recommended because it makes the application
dependent on environments which rely on these directory structures.

These might not work in different distros or even on a sandbox.
Comment 2 Felipe Borges 2017-04-20 10:09:00 UTC
Created attachment 350110 [details] [review]
flatpak: Add org.gnome.Usage flatpak manifest

This will make it significantly easier for other developers
to contribute to GNOME Usage.
Comment 3 Felipe Borges 2017-04-20 10:12:22 UTC
After these changes are on git master, it will be as easy as:

1. Open GNOME Builder
2. Click on [Clone]
3. Type git://git.gnome.org/gnome-usage in the path entry
4. Press the Play (▶) button 

To run/test the application.

It is important to notice that, so far with this version, Usage won't be able to list any other process of the system because it is running in a sandbox with strict access to the operating system.

There are "holes" that can be used to access the required data but the main motivation of this patch/bug/flatpak-manifest is just to make it easier for developers to contribute to GNOME Usage.
Comment 4 Petr Štětka 2017-04-20 13:35:08 UTC
Review of attachment 350109 [details] [review]:

Accepted
Comment 5 Felipe Borges 2017-04-20 13:45:42 UTC
Created attachment 350127 [details] [review]
build: Compile GSchemas in post install

This is necessary when building from the source code.
Comment 6 Petr Štětka 2017-04-20 14:01:41 UTC
Review of attachment 350127 [details] [review]:

Accepted
Comment 7 Petr Štětka 2017-04-20 14:04:46 UTC
Review of attachment 350110 [details] [review]:

Accepted
Comment 8 Felipe Borges 2017-04-20 14:11:04 UTC
Attachment 350109 [details] pushed as 58aefe4 - build: Do not include absolute paths
Attachment 350110 [details] pushed as 15544e0 - flatpak: Add org.gnome.Usage flatpak manifest
Attachment 350127 [details] pushed as 0f48360 - build: Compile GSchemas in post install

Thank you!

For the record, by running Usage in a sandbox as it is now causes the Storage tab not to show anything because it doesn't have access to the root filesystem tree.