GNOME Bugzilla – Bug 781516
solid lines are still drawn with zero width
Last modified: 2017-04-25 16:25:36 UTC
Created attachment 350099 [details] [review] the patch to do that For consistency reasons, it probably makes sense to change the line width to `1` in *all* calls of `gdk_gc_set_line_attributes`: general idea is that, given the type of `line_width` is `gint`, `1` is the minimum, while `0` should be invisible.
Review of attachment 350099 [details] [review]: Commit message subject lines should be less than 50 characters if possible (and it is very much so here) and not end with a period. Here’s a possible rephrased commit message: "Make the solid lines 1px wide for consistency". The rest of the patch looks good, I’ll push it as soon as you submit an updated one.
Created attachment 350194 [details] [review] updated version of the patch only changed the commit message, not the hash
Review of attachment 350194 [details] [review]: You cannot do it like that. The correct way to do it is to rewrite the commit with git. If this is your most recent commit, run `git commit --amend` and you will be able to fix the commit messsage. If this is not your most recent commit, you’ll have to use `git rebase --interactive`. More about that at https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History
Created attachment 350196 [details] [review] the patch, fixed for compliance added the Bugzilla ref. and a comma
Review of attachment 350196 [details] [review]: This has not been generated the proper way. Either use `git bz` or `git format-patch` and not `git show`.
Created attachment 350415 [details] [review] COM# Attachment to Bug 781516 - solid lines are still drawn with zero width Make the solid lines 1px wide, for consistency