After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781516 - solid lines are still drawn with zero width
solid lines are still drawn with zero width
Status: RESOLVED FIXED
Product: planner
Classification: Other
Component: Gantt
unspecified
Other Linux
: Normal normal
: ---
Assigned To: planner-maint
planner-maint
Depends on:
Blocks:
 
 
Reported: 2017-04-20 05:38 UTC by Andrew Miloradovsky
Modified: 2017-04-25 16:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
the patch to do that (1.96 KB, patch)
2017-04-20 05:38 UTC, Andrew Miloradovsky
none Details | Review
updated version of the patch (1.95 KB, patch)
2017-04-21 11:12 UTC, Andrew Miloradovsky
none Details | Review
the patch, fixed for compliance (2.01 KB, patch)
2017-04-21 11:46 UTC, Andrew Miloradovsky
needs-work Details | Review
COM# Attachment to Bug 781516 - solid lines are still drawn with zero width (2.21 KB, patch)
2017-04-25 16:20 UTC, Andrew Miloradovsky
committed Details | Review

Description Andrew Miloradovsky 2017-04-20 05:38:58 UTC
Created attachment 350099 [details] [review]
the patch to do that

For consistency reasons, it probably makes sense to change the line width to `1` in *all* calls of `gdk_gc_set_line_attributes`: general idea is that, given the type of `line_width` is `gint`, `1` is the minimum, while `0` should be invisible.
Comment 1 Alexandre Franke 2017-04-21 10:54:03 UTC
Review of attachment 350099 [details] [review]:

Commit message subject lines should be less than 50 characters if possible (and it is very much so here) and not end with a period. Here’s a possible rephrased commit message: "Make the solid lines 1px wide for consistency".

The rest of the patch looks good, I’ll push it as soon as you submit an updated one.
Comment 2 Andrew Miloradovsky 2017-04-21 11:12:40 UTC
Created attachment 350194 [details] [review]
updated version of the patch

only changed the commit message, not the hash
Comment 3 Alexandre Franke 2017-04-21 11:30:42 UTC
Review of attachment 350194 [details] [review]:

You cannot do it like that. The correct way to do it is to rewrite the commit with git.

If this is your most recent commit, run `git commit --amend` and you will be able to fix the commit messsage.

If this is not your most recent commit, you’ll have to use `git rebase --interactive`.

More about that at https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History
Comment 4 Andrew Miloradovsky 2017-04-21 11:46:17 UTC
Created attachment 350196 [details] [review]
the patch, fixed for compliance

added the Bugzilla ref. and a comma
Comment 5 Alexandre Franke 2017-04-25 15:45:41 UTC
Review of attachment 350196 [details] [review]:

This has not been generated the proper way. Either use `git bz` or `git format-patch` and not `git show`.
Comment 6 Andrew Miloradovsky 2017-04-25 16:20:54 UTC
Created attachment 350415 [details] [review]
COM# Attachment to Bug 781516 - solid lines are still drawn with zero width

Make the solid lines 1px wide, for consistency